Bug 1944959: Free BaselineCompileTask even if compilation failed r=nbp

iainireland · iainireland · commit a72c16fe94a9 · 2025-02-03T20:04:32.000Z
Differential Revision: https://phabricator.services.mozilla.com/D236440
diff --git a/js/src/jit/BaselineCompileTask.cpp b/js/src/jit/BaselineCompileTask.cpp
@@ -111,8 +111,8 @@ void js::AttachFinishedBaselineCompilations(JSContext* cx,
           AutoUnlockHelperThreadState unlock(lock);
           AutoRealm ar(cx, task->script());
           task->finishOnMainThread(cx);
-          BaselineCompileTask::FinishOffThreadTask(task);
         }
+        BaselineCompileTask::FinishOffThreadTask(task);
       }
     }
     if (!found) {

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,8 @@ void js::AttachFinishedBaselineCompilations(JSContext* cx,`
`111`	`111`	`AutoUnlockHelperThreadState unlock(lock);`
`112`	`112`	`AutoRealm ar(cx, task->script());`
`113`	`113`	`task->finishOnMainThread(cx);`
`114`		`- BaselineCompileTask::FinishOffThreadTask(task);`
`115`	`114`	`}`
	`115`	`+ BaselineCompileTask::FinishOffThreadTask(task);`
`116`	`116`	`}`
`117`	`117`	`}`
`118`	`118`	`if (!found) {`