Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku

sigiesec · sigiesec · commit 86ba544cc68e · 2020-04-23T08:38:57.000Z
Differential Revision: https://phabricator.services.mozilla.com/D71786
diff --git a/dom/indexedDB/IDBCursor.cpp b/dom/indexedDB/IDBCursor.cpp
@@ -213,6 +213,11 @@ IDBCursorDirection IDBCursor::GetDirection() const {
   }
 }
 
+RefPtr<IDBRequest> IDBCursor::Request() const {
+  AssertIsOnOwningThread();
+  return mRequest;
+}
+
 template <IDBCursor::Type CursorType>
 void IDBTypedCursor<CursorType>::GetSource(
     OwningIDBObjectStoreOrIDBIndex& aSource) const {
diff --git a/dom/indexedDB/IDBCursor.h b/dom/indexedDB/IDBCursor.h
@@ -113,6 +113,8 @@ class IDBCursor : public nsISupports, public nsWrapperCache {
 
   IDBCursorDirection GetDirection() const;
 
+  RefPtr<IDBRequest> Request() const;
+
   virtual void GetKey(JSContext* aCx, JS::MutableHandle<JS::Value> aResult,
                       ErrorResult& aRv) = 0;
 
diff --git a/dom/webidl/IDBCursor.webidl b/dom/webidl/IDBCursor.webidl
@@ -27,6 +27,8 @@ interface IDBCursor {
     [Throws]
     readonly    attribute any                          primaryKey;
 
+    readonly    attribute IDBRequest                   request;
+
     [Throws]
     IDBRequest update (any value);
 
diff --git a/testing/web-platform/meta/IndexedDB/idbcursor-request.any.js.ini b/testing/web-platform/meta/IndexedDB/idbcursor-request.any.js.ini
diff --git a/testing/web-platform/meta/IndexedDB/idlharness.any.js.ini b/testing/web-platform/meta/IndexedDB/idlharness.any.js.ini
@@ -5,9 +5,6 @@
   [IDBFactory interface: operation databases()]
     expected: FAIL
 
-  [IDBCursor interface: attribute request]
-    expected: FAIL
-
   [IDBTransaction interface: attribute durability]
     expected: FAIL
 
@@ -19,9 +16,6 @@
   [IDBFactory interface: operation databases()]
     expected: FAIL
 
-  [IDBCursor interface: attribute request]
-    expected: FAIL
-
   [IDBTransaction interface: attribute durability]
     expected: FAIL
 
@@ -33,9 +27,6 @@
   [IDBFactory interface: operation databases()]
     expected: FAIL
 
-  [IDBCursor interface: attribute request]
-    expected: FAIL
-
   [IDBTransaction interface: attribute durability]
     expected: FAIL
 
@@ -50,9 +41,6 @@
   [IDBFactory interface: operation databases()]
     expected: FAIL
 
-  [IDBCursor interface: attribute request]
-    expected: FAIL
-
   [IDBTransaction interface: attribute durability]
     expected: FAIL
 

Original file line number	Diff line number	Diff line change
`@@ -213,6 +213,11 @@ IDBCursorDirection IDBCursor::GetDirection() const {`
`213`	`213`	`}`
`214`	`214`	`}`
`215`	`215`
	`216`	`+RefPtr<IDBRequest> IDBCursor::Request() const {`
	`217`	`+ AssertIsOnOwningThread();`
	`218`	`+ return mRequest;`
	`219`	`+}`
	`220`	`+`
`216`	`221`	`template <IDBCursor::Type CursorType>`
`217`	`222`	`void IDBTypedCursor<CursorType>::GetSource(`
`218`	`223`	`OwningIDBObjectStoreOrIDBIndex& aSource) const {`