Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 8687ca2

Browse files
committed
Bug 1574475 - Don't check marionette FTP proxy support in test_session.js r=whimboo,marionette-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D112906
1 parent 8f48af1 commit 8687ca2

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

testing/marionette/test/unit/test_session.js

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,6 @@ const {
2222
WebDriverSession,
2323
} = ChromeUtils.import("chrome://marionette/content/session.js");
2424

25-
// FTP protocol handler is needed for ftpProxy tests
26-
registerCleanupFunction(function() {
27-
Preferences.reset("network.ftp.enabled");
28-
});
29-
Preferences.set("network.ftp.enabled", true);
30-
3125
add_test(function test_WebDriverSession_ctor() {
3226
const session = new WebDriverSession();
3327

@@ -157,7 +151,6 @@ add_test(function test_Proxy_ctor() {
157151
"proxyType",
158152
"httpProxy",
159153
"sslProxy",
160-
"ftpProxy",
161154
"socksProxy",
162155
"socksVersion",
163156
"proxyAutoconfigUrl",
@@ -207,7 +200,7 @@ add_test(function test_Proxy_init() {
207200
equal(Preferences.get("network.proxy.type"), 5);
208201

209202
// manual
210-
for (let proxy of ["ftp", "http", "ssl", "socks"]) {
203+
for (let proxy of ["http", "ssl", "socks"]) {
211204
p = new Proxy();
212205
p.proxyType = "manual";
213206
p.noProxy = ["foo", "bar"];
@@ -258,7 +251,7 @@ add_test(function test_Proxy_toJSON() {
258251
p.proxyType = "manual";
259252
deepEqual(p.toJSON(), { proxyType: "manual" });
260253

261-
for (let proxy of ["ftpProxy", "httpProxy", "sslProxy", "socksProxy"]) {
254+
for (let proxy of ["httpProxy", "sslProxy", "socksProxy"]) {
262255
let expected = { proxyType: "manual" };
263256

264257
p = new Proxy();
@@ -336,7 +329,7 @@ add_test(function test_Proxy_fromJSON() {
336329
p.proxyType = "manual";
337330
deepEqual(p, Proxy.fromJSON({ proxyType: "manual" }));
338331

339-
for (let proxy of ["httpProxy", "sslProxy", "ftpProxy", "socksProxy"]) {
332+
for (let proxy of ["httpProxy", "sslProxy", "socksProxy"]) {
340333
let manual = { proxyType: "manual" };
341334

342335
// invalid hosts
@@ -394,7 +387,7 @@ add_test(function test_Proxy_fromJSON() {
394387
if (proxy === "socksProxy") {
395388
p[`${proxy}Port`] = null;
396389
} else {
397-
let default_ports = { ftpProxy: 21, httpProxy: 80, sslProxy: 443 };
390+
let default_ports = { httpProxy: 80, sslProxy: 443 };
398391

399392
p[`${proxy}Port`] = default_ports[proxy];
400393
}

0 commit comments

Comments
 (0)