Issues on 3locales page when locales 2 and 3 are identical

[TheoChevalier]

For example on this page: https://transvision.mozfr.org/3locales/?recherche=test&repo=aurora&sourcelocale=en-US&locale=sr&locale2=sr&search_type=strings

The 3rd header is missing, and links to source files are broken for the 3rd locale. This is caused by this check https://github.com/mozfr/transvision/blob/master/app/classes/Transvision/Search.php#L395-396

Before considering removing or working around it, I’d like to understand why it’s here :) I assume it’s because it’s conceptually false to state we have 3 locales while 2 are the same one. But that might be something else since currently “Source locale” and “extra locale” can be the same, we’re only checking locales 2 and 3.

Maybe on the 3locales page, we should redirect to the main search if we detect the 3rd locale is identical to the second one? Or just remove this check?

I think we should redirect to the main search if the 3rd locale is the same as the 2nd one