Skip to content

Commit 9101e34

Browse files
committed
Do not fire FilesAdded with the whole queue every time. Address #1073.
1 parent 3912c24 commit 9101e34

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/plupload.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1873,6 +1873,7 @@ plupload.Uploader = function(options) {
18731873
addFile : function(file, fileName) {
18741874
var self = this
18751875
, queue = []
1876+
, filesAdded = []
18761877
, ruid
18771878
;
18781879

@@ -1924,7 +1925,11 @@ plupload.Uploader = function(options) {
19241925
// run through the internal and user-defined filters, if any
19251926
filterFile(file, function(err) {
19261927
if (!err) {
1928+
// make files available for the filters by updating the main queue directly
19271929
files.push(file);
1930+
// collect the files that will be passed to FilesAdded event
1931+
filesAdded.push(file);
1932+
19281933
self.trigger("FileFiltered", file);
19291934
}
19301935
delay(cb, 1); // do not build up recursions or eventually we might hit the limits
@@ -1954,8 +1959,8 @@ plupload.Uploader = function(options) {
19541959
if (queue.length) {
19551960
o.inSeries(queue, function() {
19561961
// if any files left after filtration, trigger FilesAdded
1957-
if (files.length) {
1958-
self.trigger("FilesAdded", files);
1962+
if (filesAdded.length) {
1963+
self.trigger("FilesAdded", filesAdded);
19591964
}
19601965
});
19611966
}

0 commit comments

Comments
 (0)