What are our criteria for a correct state migration?

[l-monninger]

Summary

We do not have criteria for a successful state migration from movement to maptos-core. It is unknown both (a) what changes have been made to representations in the state database and (b) whether semantics have changed s.t. these representations might not be naively interpreted.

We should be able to research this by carefully examining the release notes and diffs in aptos-core. It could be that there is not much.

Ultimately, I would suggest populate the criterion APIs described here with very precise descriptions of these criteria.

I will raise a separate discussion to cover a possible "pass" approach to organizing the actual migration logic w.r.t. to these criteria.

[l-monninger]

One initial criterion we can attempt is that, when viewing via the StateView, all global storage values (address, module::type) are available and equivalent. Because the types, I believe will be different, we'll have to expand this notion of equivalence later on. I will break this initial effort out into an issue.

[l-monninger]

See #8

[l-monninger]

I also added an injectivity check as a lower bound.

[l-monninger]

Per #33, we now have GlobalStorageNotEmpty, GlobalStorageInjective, and GlobalStorageIncludes.