From fa26bd044782b818e20fb42531eb27943f1156eb Mon Sep 17 00:00:00 2001 From: Paul Sharpe Date: Sat, 5 Oct 2024 08:16:51 +0100 Subject: [PATCH 1/3] vscode extension: Find globalPath on windows Update version to 0.13.1 issue #1673 --- packages/vscode-extension/package.json | 2 +- packages/vscode-extension/src/workspace.ts | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/vscode-extension/package.json b/packages/vscode-extension/package.json index ece9e31..63ccf49 100644 --- a/packages/vscode-extension/package.json +++ b/packages/vscode-extension/package.json @@ -1,6 +1,6 @@ { "private": true, - "version": "0.13.0", + "version": "0.13.1", "name": "moon-console", "publisher": "moonrepo", "displayName": "moon console", diff --git a/packages/vscode-extension/src/workspace.ts b/packages/vscode-extension/src/workspace.ts index be81c8c..093a754 100644 --- a/packages/vscode-extension/src/workspace.ts +++ b/packages/vscode-extension/src/workspace.ts @@ -176,7 +176,13 @@ export class Workspace { } try { - const globalBin = execa.sync('which', ['moon']).stdout; + let globalBin = ""; + if (process.platform == 'win32') { + globalBin = execa.sync('cmd', ['/c','where','moon']).stdout; + } + else{ + globalBin = execa.sync('which', ['moon']).stdout; + } if (globalBin && fs.existsSync(globalBin)) { return globalBin; From 5b95a1553685831f46abbda01ae6dcc116a066a5 Mon Sep 17 00:00:00 2001 From: Paul Sharpe Date: Mon, 7 Oct 2024 15:00:12 +0100 Subject: [PATCH 2/3] Correct lint error --- packages/vscode-extension/src/workspace.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vscode-extension/src/workspace.ts b/packages/vscode-extension/src/workspace.ts index 093a754..bb7729c 100644 --- a/packages/vscode-extension/src/workspace.ts +++ b/packages/vscode-extension/src/workspace.ts @@ -177,7 +177,7 @@ export class Workspace { try { let globalBin = ""; - if (process.platform == 'win32') { + if (process.platform === 'win32') { globalBin = execa.sync('cmd', ['/c','where','moon']).stdout; } else{ From 8160ed52c574a4ac61d8b9f79012938c44576ce9 Mon Sep 17 00:00:00 2001 From: Paul Sharpe Date: Mon, 7 Oct 2024 20:36:33 +0100 Subject: [PATCH 3/3] Fix Formatting error --- packages/vscode-extension/src/workspace.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/vscode-extension/src/workspace.ts b/packages/vscode-extension/src/workspace.ts index bb7729c..8f22e6d 100644 --- a/packages/vscode-extension/src/workspace.ts +++ b/packages/vscode-extension/src/workspace.ts @@ -176,11 +176,10 @@ export class Workspace { } try { - let globalBin = ""; + let globalBin = ''; if (process.platform === 'win32') { - globalBin = execa.sync('cmd', ['/c','where','moon']).stdout; - } - else{ + globalBin = execa.sync('cmd', ['/c', 'where', 'moon']).stdout; + } else { globalBin = execa.sync('which', ['moon']).stdout; }