perf: optimize friend queries (@fehmer) #7080
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
force-pushed
the
feature/perf-friend-queries
branch
from
300fda8 to
b2f3c48
Compare
fehmer
force-pushed
the
feature/perf-friend-queries
branch
from
b2f3c48 to
c74b792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine two queries (first get all friend UIDs, then call leaderboard) into one query to reduce db roundtrips.
Use the same approach for the friends list in user dal.
Note: when updating mongodb to 6+ we could use unionWith in case we don't need the metadata (lb use-case)