Skip to content

Conversation

@AmanDevelops
Copy link

Description

Added input validation for New filter preset modal in frontend and display appropriate indicators in realtime

Updated UI

Screenshot From 2025-11-03 02-08-40 Screenshot From 2025-11-03 02-08-26

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • Add theme css file to frontend/static/themes
    • Add some screenshot of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the themes documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #7063

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Nov 2, 2025
@fehmer
Copy link
Member

fehmer commented Nov 2, 2025

hi @AmanDevelops , thank you for your contribution.

I think we should use this opportunity to convert the newFilterPresetModal into a SimpleModal which has build in schema validation.

Example:
https://github.com/monkeytypegame/monkeytype/blob/master/frontend/src/ts/pages/friends.ts#L68-L121

@AmanDevelops
Copy link
Author

AmanDevelops commented Nov 3, 2025

updated to use SimpleModal as requested. let me know if any further changes are required.

Screenshot From 2025-11-04 03-28-28 Screenshot From 2025-11-04 03-28-48

notifications are working as required

Screenshot From 2025-11-04 03-30-17

@fehmer
Copy link
Member

fehmer commented Nov 3, 2025

Some leftovers to be deleted:

@AmanDevelops
Copy link
Author

Removed the leftover modal code and styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No visual validation for some fields

3 participants