fix: Fix invalid preset name (@Leonabcd123) #7068
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you, however this is a bit of a band-aid fix. Sorry, but Ill commit a proper fix. |
Contributor
Author
|
Maybe if we can get it so when a user closes the edit preset name popup, it automatically updates it to the last saved name (that we know is valid), instead of the one currently in the input element? |
Member
I just opted for not checking the input if its not needed (when deleting). Seems to me like the solution that makes most sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated input element to use the valid saved name instead of the current, potentially invalid one.
Closes #7064