fix(challenge): prevent duplicate AFK performance notification (#7045)

Author: SachinSingh008

frontend/src/ts/controllers/challenge-controller.ts

@@ -37,7 +37,7 @@ export function clearActive(): void {
 function verifyRequirement(
   result: CompletedEvent,
   requirements: NonNullable<Challenge["requirements"]>,
-  requirementType: keyof NonNullable<Challenge["requirements"]>
+  requirementType: keyof NonNullable<Challenge["requirements"]>,
 ): [boolean, string[]] {
   let requirementsMet = true;
   let failReasons: string[] = [];
@@ -146,27 +146,36 @@ export function verify(result: CompletedEvent): string | null {
   try {
     const afk = (result.afkDuration / result.testDuration) * 100;
 
+    // Show a challenge-specific notification when AFK percentage exceeds 10%
     if (afk > 10) {
-      Notifications.add(`Challenge failed: AFK time is greater than 10%`, 0);
+      // Safe access to challenge display name with fallback
+      const activeChallengeName =
+        TestState.activeChallenge?.display ?? "Challenge";
+
+      Notifications.add(
+        `${activeChallengeName} incomplete: Away for ${Math.round(afk)}% of test`,
+        0,
+        { duration: 4 },
+      );
       return null;
     }
 
     if (TestState.activeChallenge.requirements === undefined) {
       Notifications.add(
         `${TestState.activeChallenge.display} challenge passed!`,
-        1
+        1,
       );
       return TestState.activeChallenge.name;
     } else {
       let requirementsMet = true;
       const failReasons: string[] = [];
       for (const requirementType of Misc.typedKeys(
-        TestState.activeChallenge.requirements
+        TestState.activeChallenge.requirements,
       )) {
         const [passed, requirementFailReasons] = verifyRequirement(
           result,
           TestState.activeChallenge.requirements,
-          requirementType
+          requirementType,
         );
         if (!passed) {
           requirementsMet = false;
@@ -180,20 +189,20 @@ export function verify(result: CompletedEvent): string | null {
             1,
             {
               duration: 5,
-            }
+            },
           );
         }
         Notifications.add(
           `${TestState.activeChallenge.display} challenge passed!`,
-          1
+          1,
         );
         return TestState.activeChallenge.name;
       } else {
         Notifications.add(
           `${
             TestState.activeChallenge.display
           } challenge failed: ${failReasons.join(", ")}`,
-          0
+          0,
         );
         return null;
       }
@@ -202,7 +211,7 @@ export function verify(result: CompletedEvent): string | null {
     console.error(e);
     Notifications.add(
       `Something went wrong when verifying challenge: ${(e as Error).message}`,
-      0
+      0,
     );
     return null;
   }
@@ -226,7 +235,7 @@ export async function setup(challengeName: string): Promise<boolean> {
   }
 
   const challenge = list.find(
-    (c) => c.name.toLowerCase() === challengeName.toLowerCase()
+    (c) => c.name.toLowerCase() === challengeName.toLowerCase(),
   );
   let notitext;
   try {
@@ -263,7 +272,7 @@ export async function setup(challengeName: string): Promise<boolean> {
     } else if (challenge.type === "script") {
       Loader.show();
       const response = await fetch(
-        "/challenges/" + (challenge.parameters[0] as string)
+        "/challenges/" + (challenge.parameters[0] as string),
       );
       Loader.hide();
       if (response.status !== 200) {
@@ -330,7 +339,7 @@ export async function setup(challengeName: string): Promise<boolean> {
   } catch (e) {
     Notifications.add(
       Misc.createErrorMessage(e, "Failed to load challenge"),
-      -1
+      -1,
     );
     return false;
   }