fix flaky tests

Author: fehmer

backend/__tests__/__integration__/dal/friends.spec.ts

@@ -5,7 +5,7 @@ import { createUser, pb } from "../../__testData__/users";
 
 describe("FriendsDal", () => {
   beforeAll(async () => {
-    FriendsDal.createIndicies();
+    await FriendsDal.createIndicies();
   });
 
   describe("getRequests", () => {

backend/__tests__/__integration__/dal/user.spec.ts

@@ -126,22 +126,24 @@ describe("UserDal", () => {
 
   it("isNameAvailable should correctly check if a username is available", async () => {
     // given
-    const { uid: user1 } = await UserTestData.createUser({ name: "user1" });
-    await UserTestData.createUser({ name: "user2" });
+    const name1 = "user" + new ObjectId().toHexString();
+    const name2 = "user" + new ObjectId().toHexString();
+    const { uid: user1 } = await UserTestData.createUser({ name: name1 });
+    await UserTestData.createUser({ name: name2 });
 
     const testCases = [
       {
-        name: "user1",
+        name: name1,
         whosChecking: user1,
         expected: true,
       },
       {
-        name: "USER1",
+        name: name1.toUpperCase(),
         whosChecking: user1,
         expected: true,
       },
       {
-        name: "user2",
+        name: name2,
         whosChecking: user1,
         expected: false,
       },
@@ -184,14 +186,16 @@ describe("UserDal", () => {
 
   it("UserDAL.updateName should change the name of a user", async () => {
     // given
-    const testUser = await UserTestData.createUser({ name: "bob" });
+    const name = "user" + new ObjectId().toHexString();
+    const renamed = "renamed" + new ObjectId().toHexString();
+    const testUser = await UserTestData.createUser({ name: name });
 
     // when
-    await UserDAL.updateName(testUser.uid, "renamedTestUser", testUser.name);
+    await UserDAL.updateName(testUser.uid, renamed, testUser.name);
 
     // then
     const updatedUser = await UserDAL.getUser(testUser.uid, "test");
-    expect(updatedUser.name).toBe("renamedTestUser");
+    expect(updatedUser.name).toBe(renamed);
   });
 
   it("clearPb should clear the personalBests of a user", async () => {
@@ -1472,8 +1476,9 @@ describe("UserDal", () => {
     });
   });
   describe("isDiscordIdAvailable", () => {
+    const discordId = new ObjectId().toHexString();
     it("should return true for available discordId", async () => {
-      await expect(UserDAL.isDiscordIdAvailable("myId")).resolves.toBe(true);
+      await expect(UserDAL.isDiscordIdAvailable(discordId)).resolves.toBe(true);
     });
 
     it("should return false if discordId is taken", async () => {