test: fix flaky user tests (@fehmer)

Author: fehmer

backend/__tests__/__integration__/dal/user.spec.ts

@@ -126,22 +126,24 @@ describe("UserDal", () => {
 
   it("isNameAvailable should correctly check if a username is available", async () => {
     // given
-    const { uid: user1 } = await UserTestData.createUser({ name: "user1" });
-    await UserTestData.createUser({ name: "user2" });
+    const name1 = "user" + new ObjectId().toHexString();
+    const name2 = "user" + new ObjectId().toHexString();
+    const { uid: user1 } = await UserTestData.createUser({ name: name1 });
+    await UserTestData.createUser({ name: name2 });
 
     const testCases = [
       {
-        name: "user1",
+        name: name1,
         whosChecking: user1,
         expected: true,
       },
       {
-        name: "USER1",
+        name: name1.toUpperCase(),
         whosChecking: user1,
         expected: true,
       },
       {
-        name: "user2",
+        name: name2,
         whosChecking: user1,
         expected: false,
       },
@@ -156,8 +158,10 @@ describe("UserDal", () => {
 
   it("updatename should not allow unavailable usernames", async () => {
     // given
-    const user1 = await UserTestData.createUser({ name: "bob" });
-    const user2 = await UserTestData.createUser({ name: "kevin" });
+    const name1 = "user" + new ObjectId().toHexString();
+    const name2 = "user" + new ObjectId().toHexString();
+    const user1 = await UserTestData.createUser({ name: name1 });
+    const user2 = await UserTestData.createUser({ name: name2 });
     const _decoy = await UserTestData.createUser();
 
     // when, then
@@ -167,36 +171,40 @@ describe("UserDal", () => {
   });
 
   it("same usernames (different casing) should be available only for the same user", async () => {
-    const user1 = await UserTestData.createUser({ name: "bob" });
-    const user2 = await UserTestData.createUser({ name: "kevin" });
+    const name1 = "user" + new ObjectId().toHexString();
+    const name2 = "user" + new ObjectId().toHexString();
+    const user1 = await UserTestData.createUser({ name: name1 });
+    const user2 = await UserTestData.createUser({ name: name2 });
 
-    await UserDAL.updateName(user1.uid, "BOB", user1.name);
+    await UserDAL.updateName(user1.uid, name1.toUpperCase(), user1.name);
 
     const updatedUser1 = await UserDAL.getUser(user1.uid, "test");
 
     // when, then
-    expect(updatedUser1.name).toBe("BOB");
+    expect(updatedUser1.name).toBe(name1.toUpperCase());
 
     await expect(
-      UserDAL.updateName(user2.uid, "bob", user2.name)
+      UserDAL.updateName(user2.uid, name1, user2.name)
     ).rejects.toThrow("Username already taken");
   });
 
   it("UserDAL.updateName should change the name of a user", async () => {
     // given
-    const testUser = await UserTestData.createUser({ name: "bob" });
+    const name = "user" + new ObjectId().toHexString();
+    const renamed = "renamed" + new ObjectId().toHexString();
+    const testUser = await UserTestData.createUser({ name: name });
 
     // when
-    await UserDAL.updateName(testUser.uid, "renamedTestUser", testUser.name);
+    await UserDAL.updateName(testUser.uid, renamed, testUser.name);
 
     // then
     const updatedUser = await UserDAL.getUser(testUser.uid, "test");
-    expect(updatedUser.name).toBe("renamedTestUser");
+    expect(updatedUser.name).toBe(renamed);
   });
 
   it("clearPb should clear the personalBests of a user", async () => {
     // given
-    const testUser = await UserTestData.createUser({ name: "bob" });
+    const testUser = await UserTestData.createUser();
     await UserDAL.getUsersCollection().updateOne(
       { uid: testUser.uid },
       {
@@ -233,7 +241,7 @@ describe("UserDal", () => {
 
   it("autoBan should automatically ban after configured anticheat triggers", async () => {
     // given
-    const testUser = await UserTestData.createUser({ name: "bob" });
+    const testUser = await UserTestData.createUser();
 
     // when
     Date.now = vi.fn(() => 0);
@@ -249,7 +257,7 @@ describe("UserDal", () => {
 
   it("autoBan should not ban ban if triggered once", async () => {
     // given
-    const testUser = await UserTestData.createUser({ name: "bob" });
+    const testUser = await UserTestData.createUser();
 
     // when
     Date.now = vi.fn(() => 0);
@@ -263,7 +271,7 @@ describe("UserDal", () => {
 
   it("autoBan should correctly remove old anticheat triggers", async () => {
     // given
-    const testUser = await UserTestData.createUser({ name: "bob" });
+    const testUser = await UserTestData.createUser();
 
     // when
     Date.now = vi.fn(() => 0);
@@ -1240,7 +1248,6 @@ describe("UserDal", () => {
       };
 
       let user = await UserTestData.createUser({
-        name: "bob",
         xp: 100,
         inbox: [rewardOne, rewardTwo, rewardThree, rewardFour],
       });
@@ -1473,17 +1480,21 @@ describe("UserDal", () => {
   });
   describe("isDiscordIdAvailable", () => {
     it("should return true for available discordId", async () => {
-      await expect(UserDAL.isDiscordIdAvailable("myId")).resolves.toBe(true);
+      const discordId = new ObjectId().toHexString();
+      await expect(UserDAL.isDiscordIdAvailable(discordId)).resolves.toBe(true);
     });
 
     it("should return false if discordId is taken", async () => {
       // given
+      const discordId = new ObjectId().toHexString();
       await UserTestData.createUser({
-        discordId: "myId",
+        discordId: discordId,
       });
 
       // when, then
-      await expect(UserDAL.isDiscordIdAvailable("myId")).resolves.toBe(false);
+      await expect(UserDAL.isDiscordIdAvailable(discordId)).resolves.toBe(
+        false
+      );
     });
   });
   describe("updateLbMemory", () => {
@@ -1566,8 +1577,9 @@ describe("UserDal", () => {
 
     it("increments bananas", async () => {
       //GIVEN
+      const name = "user" + new ObjectId().toHexString();
       const { uid } = await UserTestData.createUser({
-        name: "bob",
+        name,
         bananas: 1,
         personalBests: {
           time: {
@@ -1584,7 +1596,7 @@ describe("UserDal", () => {
       await UserDAL.incrementBananas(uid, 75);
       const read = await UserDAL.getUser(uid, "read");
       expect(read.bananas).toEqual(2);
-      expect(read.name).toEqual("bob");
+      expect(read.name).toEqual(name);
 
       //NOT within 25% of PB
       await UserDAL.incrementBananas(uid, 74);
@@ -1594,7 +1606,6 @@ describe("UserDal", () => {
     it("ignores missing personalBests", async () => {
       //GIVEN
       const { uid } = await UserTestData.createUser({
-        name: "bob",
         bananas: 1,
       });
 
@@ -1608,7 +1619,6 @@ describe("UserDal", () => {
     it("ignores missing personalBests time", async () => {
       //GIVEN
       const { uid } = await UserTestData.createUser({
-        name: "bob",
         bananas: 1,
         personalBests: {} as any,
       });
@@ -1622,7 +1632,6 @@ describe("UserDal", () => {
     it("ignores missing personalBests time 60", async () => {
       //GIVEN
       const { uid } = await UserTestData.createUser({
-        name: "bob",
         bananas: 1,
         personalBests: { time: {} } as any,
       });
@@ -1636,7 +1645,6 @@ describe("UserDal", () => {
     it("ignores empty personalBests time 60", async () => {
       //GIVEN
       const { uid } = await UserTestData.createUser({
-        name: "bob",
         bananas: 1,
         personalBests: { time: { "60": [] } } as any,
       });
@@ -1650,7 +1658,6 @@ describe("UserDal", () => {
     it("should increment missing bananas", async () => {
       //GIVEN
       const { uid } = await UserTestData.createUser({
-        name: "bob",
         personalBests: { time: { "60": [{ wpm: 100 }] } } as any,
       });
 
@@ -1869,7 +1876,6 @@ describe("UserDal", () => {
     it("addFavoriteQuote success", async () => {
       // given
       const { uid } = await UserTestData.createUser({
-        name: "bob",
         favoriteQuotes: {
           english: ["1"],
           german: ["2"],
@@ -1882,9 +1888,6 @@ describe("UserDal", () => {
 
       // then
       const read = await UserDAL.getUser(uid, "read");
-      expect(read.name).toEqual("bob");
-      expect(read).not.toHaveProperty("tmp");
-
       expect(read.favoriteQuotes).toStrictEqual({
         english: ["1", "4"],
         german: ["2"],
@@ -1895,7 +1898,6 @@ describe("UserDal", () => {
     it("should not add a quote twice", async () => {
       // given
       const { uid } = await UserTestData.createUser({
-        name: "bob",
         favoriteQuotes: {
           english: ["1", "3", "4"],
           german: ["2"],
@@ -1906,8 +1908,6 @@ describe("UserDal", () => {
 
       // then
       const read = await UserDAL.getUser(uid, "read");
-      expect(read.name).toEqual("bob");
-      expect(read).not.toHaveProperty("tmp");
 
       expect(read.favoriteQuotes).toStrictEqual({
         english: ["1", "3", "4"],