remove defaultTrue

Author: lantoli

internal/common/autogen/handle_operations.go

@@ -205,7 +205,7 @@ func addError(d *diag.Diagnostics, opName, errSummary string, err error) {
 }
 
 // callAPIWithBody makes a request to the API with the given request body and returns the response body.
-// It is used for POST, PUT, PATCH, and DELETE with static content.
+// It is used for POST, PUT, PATCH and DELETE with static content.
 func callAPIWithBody(ctx context.Context, client *config.MongoDBClient, callParams *config.APICallParams, bodyReq []byte) ([]byte, *http.Response, error) {
 	apiResp, err := client.UntypedAPICall(ctx, callParams, bodyReq)
 	if err != nil {

tools/codegen/codespec/config_test.go

@@ -3,6 +3,7 @@ package codespec_test
 import (
 	"testing"
 
+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion"
 	"github.com/mongodb/terraform-provider-mongodbatlas/tools/codegen/codespec"
 	"github.com/stretchr/testify/assert"
 )
@@ -91,8 +92,6 @@ func TestApplyTimeoutTransformation(t *testing.T) {
 }
 
 func TestApplyDeleteOnCreateTimeoutTransformation(t *testing.T) {
-	defaultTrue := true
-
 	tests := map[string]struct {
 		inputOperations                codespec.APIOperations
 		shouldAddDeleteOnCreateTimeout bool
@@ -170,7 +169,7 @@ func TestApplyDeleteOnCreateTimeoutTransformation(t *testing.T) {
 				expectedAttr := codespec.Attribute{
 					TFSchemaName:             "delete_on_create_timeout",
 					TFModelName:              "DeleteOnCreateTimeout",
-					Bool:                     &codespec.BoolAttribute{Default: &defaultTrue},
+					Bool:                     &codespec.BoolAttribute{Default: conversion.Pointer(true)},
 					Description:              &description,
 					ReqBodyUsage:             codespec.OmitAlways,
 					CreateOnly:               true,