fix: Adds "state_name" to keepUnknown list to prevent copying volatile attributes from state (#3040)

EspenAlbert · web-flow · commit 9edcf5250b79 · 2025-02-07T08:36:02.000Z
diff --git a/internal/service/advancedclustertpf/plan_modifier.go b/internal/service/advancedclustertpf/plan_modifier.go
@@ -22,7 +22,7 @@ func useStateForUnknowns(ctx context.Context, diags *diag.Diagnostics, plan, sta
 }
 
 func determineKeepUnknowns(upgradeRequest *admin.LegacyAtlasTenantClusterUpgradeRequest, patchReq *admin.ClusterDescription20240805) []string {
-	keepUnknown := []string{"connection_strings"} // ConnectionStrings is volatile and should not be copied from state
+	keepUnknown := []string{"connection_strings", "state_name"} // Volatile attributes, should not be copied from state
 	if upgradeRequest != nil {
 		// TenantUpgrade changes a few root level fields that are normally ok to use state values for
 		keepUnknown = append(keepUnknown, "disk_size_gb", "cluster_id", "replication_specs", "backup_enabled", "create_date")

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ func useStateForUnknowns(ctx context.Context, diags *diag.Diagnostics, plan, sta`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`func determineKeepUnknowns(upgradeRequest admin.LegacyAtlasTenantClusterUpgradeRequest, patchReq admin.ClusterDescription20240805) []string {`
`25`		`- keepUnknown := []string{"connection_strings"} // ConnectionStrings is volatile and should not be copied from state`
	`25`	`+ keepUnknown := []string{"connection_strings", "state_name"} // Volatile attributes, should not be copied from state`
`26`	`26`	`if upgradeRequest != nil {`
`27`	`27`	`// TenantUpgrade changes a few root level fields that are normally ok to use state values for`
`28`	`28`	`keepUnknown = append(keepUnknown, "disk_size_gb", "cluster_id", "replication_specs", "backup_enabled", "create_date")`