MONGOID-5456 cast castable values for integer/float/big decimal (#5431)

* MONGOID-5456 cast castable values for integer/float/big decimal

* MONGOID-5456 assert duration

Author: neilshweky

lib/mongoid/extensions/big_decimal.rb

@@ -72,10 +72,14 @@ def mongoize(object)
               BSON::Decimal128.new(object)
             elsif object.numeric?
               BSON::Decimal128.new(object.to_s)
+            elsif !object.is_a?(String)
+              object.try(:to_d)
             end
           else
             if object.is_a?(BSON::Decimal128) || object.numeric?
               object.to_s
+            elsif !object.is_a?(String)
+              object.try(:to_d)
             end
           end
         end

lib/mongoid/extensions/float.rb

@@ -37,8 +37,12 @@ module ClassMethods
         # @return [ Float | nil ] The object mongoized or nil.
         def mongoize(object)
           return if object.blank?
-          if object.numeric?
-            object.to_f
+          if object.is_a?(String)
+            if object.numeric?
+              object.to_f
+            end
+          else
+            object.try(:to_f)
           end
         end
         alias :demongoize :mongoize

lib/mongoid/extensions/integer.rb

@@ -45,8 +45,12 @@ module ClassMethods
         # @return [ Integer | nil ] The object mongoized or nil.
         def mongoize(object)
           return if object.blank?
-          if object.numeric?
-            object.to_i
+          if object.is_a?(String)
+            if object.numeric?
+              object.to_i
+            end
+          else
+            object.try(:to_i)
           end
         end
         alias :demongoize :mongoize

spec/mongoid/extensions/big_decimal_spec.rb

@@ -273,6 +273,21 @@
         end
       end
 
+      context "when the value is castable" do
+
+        let(:value) do
+          2.hours
+        end
+
+        before do
+          expect(value).to be_a(ActiveSupport::Duration)
+        end
+
+        it "returns nil" do
+          expect(mongoized).to eq(7200)
+        end
+      end
+
       context "when the value is nil" do
 
         let(:value) do

spec/mongoid/extensions/float_spec.rb

@@ -100,10 +100,10 @@
           end
         end
 
-        context "when the string is numerical" do
+        context "when the string starts with a number" do
 
-          it "returns the float value for the string" do
-            expect(Float.send(method, "3")).to eq(3)
+          it "returns nil" do
+            expect(Float.send(method, "42bogus")).to be_nil
           end
         end
 
@@ -120,6 +120,13 @@
             expect(Float.send(method, nil)).to be_nil
           end
         end
+
+        context "when giving an object that is castable to an Float" do
+
+          it "returns the integer value" do
+            expect(Float.send(method, 2.hours)).to eq(7200)
+          end
+        end
       end
     end
   end

spec/mongoid/extensions/integer_spec.rb

@@ -94,10 +94,10 @@
           end
         end
 
-        context "when the string is numerical" do
+        context "when the string starts with a number" do
 
-          it "returns the integer value for the string" do
-            expect(Integer.send(method, "3")).to eq(3)
+          it "returns nil" do
+            expect(Integer.send(method, "42bogus")).to be_nil
           end
         end
 
@@ -114,6 +114,13 @@
             expect(Integer.send(method, nil)).to be_nil
           end
         end
+
+        context "when giving an object that is castable to an Integer" do
+
+          it "returns the integer value" do
+            expect(Integer.send(method, 2.hours)).to eq(7200)
+          end
+        end
       end
     end
   end