SERVER-92292 Skip ticket acquisition for prepareTransaction to v7.0 (#29142)

GitOrigin-RevId: 88412b9d995efe255b661882e1ce002a13f7a360

Author: brad-cater-mongodb

etc/backports_required_for_multiversion_tests.yml

@@ -549,6 +549,8 @@ last-continuous:
     ticket: SERVER-91195
   - test_file: jstests/core/timeseries/timeseries_update_mixed_schema_bucket.js
     ticket: SERVER-91195
+  - test_file: jstests/sharding/coordinate_txn_commit_with_tickets_exhausted.js
+    ticket: SERVER-92292
   - test_file: jstests/core/sparse_index_supports_ne_null.js
     ticket: SERVER-37164
   - test_file: jstests/core/timeseries/timeseries_insert_mixed_schema_bucket.js
@@ -996,8 +998,6 @@ last-lts:
     ticket: SERVER-76012
   - test_file: jstests/replsets/transactions_reaped_with_tickets_exhausted.js
     ticket: SERVER-76012
-  - test_file: jstests/sharding/cancel_coordinate_txn_commit_with_tickets_exhausted.js
-    ticket: SERVER-76012
   - test_file: jstests/sharding/coordinate_txn_commit_with_tickets_exhausted.js
     ticket: SERVER-76012
   - test_file: jstests/noPassthrough/clustered_collection_sorted_scan.js
@@ -1182,6 +1182,8 @@ last-lts:
     ticket: SERVER-91195
   - test_file: jstests/core/timeseries/timeseries_update_mixed_schema_bucket.js
     ticket: SERVER-91195
+  - test_file: jstests/sharding/coordinate_txn_commit_with_tickets_exhausted.js
+    ticket: SERVER-92292
   - test_file: jstests/core/sparse_index_supports_ne_null.js
     ticket: SERVER-37164
   - test_file: jstests/core/timeseries/timeseries_insert_mixed_schema_bucket.js

jstests/sharding/cancel_coordinate_txn_commit_with_tickets_exhausted.js

@@ -1,6 +1,6 @@
 /**
- * Validate SERVER-60682: TransactionCoordinator won't starve for a storage ticket to
- * persist its decision.
+ * Validate SERVER-60682 and SERVER-92292: TransactionCoordinator won't starve for a storage ticket
+ * to prepare or commit a cross-shard transaction.
  *
  * @tags: [
  *   requires_fcv_70,
@@ -53,9 +53,12 @@ CreateShardedCollectionUtil.shardCollectionWithChunks(sourceCollection, {key: 1}
 // Insert a document into each shard.
 assert.commandWorked(sourceCollection.insert([{key: 200}, {key: -200}]));
 
+const txnCoordinator = st.rs1.getPrimary();
+
 // Create a thread which leaves the TransactionCoordinator in a state where prepareTransaction has
 // been run on both participant shards and it is about to write the commit decision locally to the
 // config.transaction_coordinators collection.
+const hangBeforeWritingDecisionFp = configureFailPoint(txnCoordinator, "hangBeforeWritingDecision");
 const preparedTxnThread = new Thread(function runTwoPhaseCommitTxn(host, dbName, collName) {
     const conn = new Mongo(host);
     const session = conn.startSession({causalConsistency: false});
@@ -66,12 +69,26 @@ const preparedTxnThread = new Thread(function runTwoPhaseCommitTxn(host, dbName,
     assert.commandWorked(sessionCollection.update({key: -200}, {$inc: {counter: 1}}));
     assert.commandWorked(session.commitTransaction_forTesting());
 }, st.s.host, sourceCollection.getDB().getName(), sourceCollection.getName());
-
-const txnCoordinator = st.rs1.getPrimary();
-const hangBeforeWritingDecisionFp = configureFailPoint(txnCoordinator, "hangBeforeWritingDecision");
-
 preparedTxnThread.start();
-hangBeforeWritingDecisionFp.wait();
+hangBeforeWritingDecisionFp.wait({timesEntered: 1});
+
+// Create a thread which leaves the TransactionCoordinator in a state where write operations has
+// been run on both participant shards and it is about to start the two-phase-commit protocol (e.g.
+// before writing the participant list).
+const hangBeforeWritingParticipantListFp =
+    configureFailPoint(txnCoordinator, "hangBeforeWritingParticipantList");
+const commitTxnThread = new Thread(function runTwoPhaseCommitTxn(host, dbName, collName) {
+    const conn = new Mongo(host);
+    const session = conn.startSession({causalConsistency: false});
+    const sessionCollection = session.getDatabase(dbName).getCollection(collName);
+
+    session.startTransaction();
+    assert.commandWorked(sessionCollection.insert({key: 300}));
+    assert.commandWorked(sessionCollection.insert({key: -300}));
+    assert.commandWorked(session.commitTransaction_forTesting());
+}, st.s.host, sourceCollection.getDB().getName(), sourceCollection.getName());
+commitTxnThread.start();
+hangBeforeWritingParticipantListFp.wait();
 
 // Create other threads which will block on a prepare conflict while still holding a write ticket to
 // test that the TransactionCoordinator from preparedTxnThread can still complete.
@@ -84,7 +101,7 @@ for (let i = 0; i < kNumWriteTickets; ++i) {
 
         session.startTransaction();
         // Do a write to ensure the transaction takes a write ticket.
-        assert.commandWorked(sessionCollection.insert({key: 300}));
+        assert.commandWorked(sessionCollection.insert({key: 100}));
         // Then do a read which will block until the prepare conflict resolves.
         assert.eq({key: 200, counter: 1}, sessionCollection.findOne({key: 200}, {_id: 0}));
         assert.commandWorked(session.commitTransaction_forTesting());
@@ -100,9 +117,23 @@ assert.soon(() => {
     return ops.length >= Math.min(prepareConflictThreads.length, kNumWriteTickets);
 }, () => `Failed to find prepare conflicts in $currentOp output: ${tojson(currentOp())}`);
 
+// Allow the commitTxnThread to proceed with preparing the transaction. This tests that we skip
+// write ticket acquisition when preparing a transaction.
+hangBeforeWritingParticipantListFp.off();
+
+jsTestLog("Waiting for commitTxnThread to successfully prepare the transaction");
+hangBeforeWritingDecisionFp.wait({timesEntered: 3});
+
+// Allow both prepared transactions to proceed with committing the transaction. This tests that we
+// skip write ticket acquisition when persisting the transaction decision and committing the
+// prepared transaction.
 hangBeforeWritingDecisionFp.off();
 
+jsTestLog("Waiting for both transactions to successfully commit");
 preparedTxnThread.join();
+commitTxnThread.join();
+
+jsTestLog("Waiting for all transactional reads to complete");
 for (let thread of prepareConflictThreads) {
     thread.join();
 }

jstests/sharding/coordinate_txn_commit_with_tickets_exhausted.js

@@ -1518,11 +1518,12 @@ void TransactionParticipant::Participant::unstashTransactionResources(OperationC
             // commitTransaction and abortTransaction commands can skip ticketing mechanism as they
             // don't acquire any new storage resources (except writing to oplog) but they release
             // any claimed storage resources.
-            // Prepared transactions should not acquire ticket. Else, it can deadlock with other
-            // non-transactional operations that have exhausted the write tickets and are blocked on
-            // them due to prepare or lock conflict.
-            if (o().txnState.isPrepared() || cmdName == "commitTransaction" ||
-                cmdName == "abortTransaction") {
+            // Prepared transactions or attempts to prepare a transaction should not acquire ticket.
+            // Else, it can deadlock with other non-transactional operations that have exhausted the
+            // write tickets and are blocked on them due to prepare or lock conflict.
+            // SERVER-41980 and SERVER-92292
+            if (o().txnState.isPrepared() || cmdName == "prepareTransaction" ||
+                cmdName == "commitTransaction" || cmdName == "abortTransaction") {
                 acquireTicket = AcquireTicket::kSkip;
             }
         } else {