Last bugfixes. Should be now fully 2.5 compliant

Author: momo_102

com_clubmanagement/backend/classes/nokCMPerson.php

@@ -338,7 +338,7 @@ function select_record() {
 		$mainframe = JFactory::getApplication(); 
 		$uri = JFactory::getURI();
 		$option = $uri->getVar('option');
-		$func = $uri->getVar('function');
+		$function = JRequest::getCmd('function', 'jSelectRecord');
 		$user =& JFactory::getUser();
 		$limit = $mainframe->getUserStateFromRequest( 'global.list.limit', 'limit', $mainframe->getCfg('list_limit'), 'int' );
 		$limitstart = $mainframe->getUserStateFromRequest( $option.'.limitstart', 'limitstart', 0, 'int' );
@@ -405,7 +405,7 @@ function select_record() {
 				echo "<td>";
 				if ($rp == 0)
 				{
-					echo "<a style=\"cursor: pointer;\" onclick=\"window.parent.".$func."('".$id."', '".$name."', 'id');\">";
+					echo "<a class=\"pointer\" onclick=\"if (window.parent) window.parent.".$function."('".$id."', '".$name."');\">";
 					echo $this->_displayField($strColumn,$field,$i);
 					echo "</a>";
 				}

com_clubmanagement/backend/classes/nokTable.class.php

@@ -947,6 +947,18 @@ function save($id=0, $cols=array()) {
 		return $result;
 	}
 
+	function get($id, $cols=array())
+	{
+		if (count($cols) < 1) $cols = $this->column_show;
+
+		//Query
+		$strSQL = $this->_calcquery($cols, "`".$this->getSetting("Primary_Key")."`=".$id, "");
+		$this->db->setQuery( $strSQL );
+		$rows = $this->db->loadRowList();
+		$row = $rows[0];
+		return $row;
+	}
+
 	function showdetail($id, $cols=array())
 	{
 		if (count($cols) < 1) $cols = $this->column_show;
@@ -962,10 +974,7 @@ function showdetail($id, $cols=array())
 		echo "<table class=\"admintable\">\n";
 
 		//Query
-		$strSQL = $this->_calcquery($cols, "`".$this->getSetting("Primary_Key")."`=".$id, "");
-		$this->db->setQuery( $strSQL );
-		$rows = $this->db->loadRowList();
-		$row = $rows[0];
+		$row = $this->get($id, $cols);
 
 		// Display
 		reset($cols);

com_clubmanagement/backend/elements/cmpersonrecord.php

@@ -40,15 +40,23 @@ protected function getInput() {
 		$cmobject	= new nokCMPerson('com_clubmanagement');
 		$db		=& JFactory::getDBO();
 		$doc 		=& JFactory::getDocument();
-		$title		= JText::_('SELECT_PERSON');
 
-		$js = "
-		function jSelectRecord(id, title, object) {
-			document.getElementById(object + '_id').value = id;
-			document.getElementById(object + '_name').value = title;
-			SqueezeBox.close();
-		}";
-		$doc->addScriptDeclaration($js);
+		$title		= "";
+		if ($this->value) {
+			$row = $cmobject->get($this->value,$cmobject->column_list);
+			$title = implode($row, " ");
+		}
+
+		// Build the script.
+		$script = array();
+		$script[] = '	function jSelectRecord_'.$this->id.'(id, name) {';
+		$script[] = '		document.id("'.$this->id.'_id").value = id;';
+		$script[] = '		document.id("'.$this->id.'_name").value = name;';
+		$script[] = '		SqueezeBox.close();';
+		$script[] = '	}';
+
+		// Add the script to the document head.
+		$doc->addScriptDeclaration(implode("\n", $script));
 
 		// Build the script.
 		$script = array();
@@ -60,7 +68,7 @@ function jSelectRecord(id, title, object) {
 		// Add the script to the document head.
 		$doc->addScriptDeclaration(implode("\n", $script));
 
-		$link = 'index.php?option=com_clubmanagement&layout=modal&task=select&cmobj=person&tmpl=component&&function=jSelectRecord';
+		$link = 'index.php?option=com_clubmanagement&layout=modal&task=select&cmobj=person&tmpl=component&&function=jSelectRecord_'.$this->id;
 
 		JHTML::_('behavior.modal', 'a.modal');
 		$html = "\n".'<div style="float: left;"><input style="background: #ffffff;" type="text" id="'.$this->id.'_name" value="'.htmlspecialchars($title, ENT_QUOTES, 'UTF-8').'" disabled="disabled" /></div>';

com_clubmanagement/backend/language/de-DE.com_clubmanagement.ini

@@ -2,7 +2,6 @@
 CLUB_MANAGEMENT="Vereinsverwaltung"
 EXPORT="Esportieren"
 IMPORT="Importieren"
-SELECT_PERSON="Person auswählen"
 BOARD="Vorstand"
 LINK="Link"
 LINK_NR="Link %s"
@@ -13,6 +12,7 @@ GO="Los"
 DETAILS="Details"
 SAVE="Speichern"
 CANCEL="Abbrechen"
+SELECT="Auswählen"
 
 ;Submenu
 SUBMENU_CLUBMANAGEMENT_PERSON="Personen"