Fix bug #153 out of order results

Author: mokkabonna

index.js

@@ -237,11 +237,11 @@ class AutocompletePrompt extends Base {
     }
 
     // Store this promise for check in the callback
-    const lastPromise = thisPromise;
+    this.lastPromise = thisPromise;
 
     return thisPromise.then((choices) => {
       // If another search is triggered before the current search finishes, don't set results
-      if (thisPromise !== lastPromise) return;
+      if (thisPromise !== this.lastPromise) return;
 
       this.currentChoices = new Choices(choices);
 

test/spec/indexSpec.js

@@ -298,6 +298,44 @@ describe('inquirer-autocomplete-prompt', () => {
     });
   });
 
+  it('does not show previous result if later result finishes before it', () => {
+    const source = sinon.stub();
+    rl = new ReadlineStub();
+    prompt = new Prompt(
+      {
+        message: 'test',
+        name: 'name',
+        source,
+      },
+      rl
+    );
+
+    // even this finishes after the second one, it should not be shown since a new call has been made
+    const promise1 = new Promise((res) => {
+      setTimeout(() => {
+        res(['result1']);
+      }, 100);
+    });
+
+    const promise2 = new Promise((res) => {
+      setTimeout(() => {
+        res(['result2']);
+      }, 10);
+    });
+    source.onCall(0).returns(promise1);
+    source.onCall(1).returns(promise2);
+
+    const runPromise = prompt.run();
+    type('c');
+
+    return promise1.then(() => {
+      enter();
+      return runPromise.then((answer) => {
+        assert.deepEqual(answer, 'result2');
+      });
+    });
+  });
+
   describe('suggestOnly = false', () => {
     beforeEach(() => {
       defaultChoices = ['foo', new inquirer.Separator(), 'bar', 'bum'];