From 156594aa6fadfacc2decd03be9179541c40b92d2 Mon Sep 17 00:00:00 2001
From: ScriptedAlchemy <zackaryjackson@bytedance.com>
Date: Mon, 3 Jun 2024 16:44:38 +0100
Subject: [PATCH] chore: general housekeeping

---
 basic-host-remote/app1/modern.config.js | 10 +++-------
 basic-host-remote/app2/modern.config.js | 10 +++-------
 2 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/basic-host-remote/app1/modern.config.js b/basic-host-remote/app1/modern.config.js
index acbcd6201a9..798a8dc10e9 100644
--- a/basic-host-remote/app1/modern.config.js
+++ b/basic-host-remote/app1/modern.config.js
@@ -1,24 +1,20 @@
 import appTools, { defineConfig } from '@modern-js/app-tools';
-import {ModuleFederationPlugin} from "@module-federation/enhanced"
+import { ModuleFederationPlugin } from '@module-federation/enhanced/webpack';
 
 // https://modernjs.dev/en/configure/app/usage
 export default defineConfig({
   server: {
     port: 3001,
   },
-  // dev: {
-  //   // set publicPath
-  //   assetPrefix: 'http://localhost:3001/',
-  // },
   runtime: {
     router: true,
   },
   source: {
-    // automatically generated asynchronous boundary via Dynamic Import, allowing the page code to consume remote modules generated by the module federation.
+    // Automatically generated asynchronous boundary via Dynamic Import, allowing the page code to consume remote modules generated by the module federation.
     enableAsyncEntry: true,
   },
   tools: {
-    webpack: (config, { webpack, appendPlugins }) => {
+    webpack: (config, { appendPlugins }) => {
       delete config.optimization.splitChunks;
       config.output.publicPath = 'auto';
 
diff --git a/basic-host-remote/app2/modern.config.js b/basic-host-remote/app2/modern.config.js
index a7feba92031..4b0c705498d 100644
--- a/basic-host-remote/app2/modern.config.js
+++ b/basic-host-remote/app2/modern.config.js
@@ -1,15 +1,11 @@
-import appTools, { defineConfig } from '@modern-js/app-tools'
-import {ModuleFederationPlugin} from "@module-federation/enhanced"
+import appTools, { defineConfig } from '@modern-js/app-tools';
+import { ModuleFederationPlugin } from '@module-federation/enhanced';
 
 // https://modernjs.dev/en/configure/app/usage
 export default defineConfig({
   server: {
     port: 3002,
   },
-  dev: {
-    // set publicPath
-    // assetPrefix: 'auto',
-  },
   runtime: {
     router: true,
   },
@@ -18,7 +14,7 @@ export default defineConfig({
     enableAsyncEntry: true,
   },
   tools: {
-    webpack: (config, { webpack, appendPlugins }) => {
+    webpack: (config, { appendPlugins }) => {
       delete config.optimization.splitChunks;
       config.output.publicPath = 'auto';