fix(modern-js-plugin): use contenthash instead of chunkhash (#3855)

Author: 2heal1

.changeset/ninety-points-impress.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/nextjs-mf': patch
+'@module-federation/node': patch
+---
+
+fix(node): use contenthash instead of chunkhash

.changeset/sour-dragons-hang.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/rsbuild-plugin': patch
+'@module-federation/modern-js': patch
+---
+
+fix(modern-js-plugin): use contenthash instead of chunkhash

apps/node-host/webpack.config.js

@@ -9,7 +9,7 @@ module.exports = composePlugins(withNx(), async (config) => {
   config.devtool = false;
   config.target = 'async-node';
   config.output.publicPath = '/testing';
-  config.output.chunkFilename = '[id]-[chunkhash].js';
+  config.output.chunkFilename = '[id]-[contenthash].js';
   config.optimization.chunkIds = 'named';
   await new Promise((r) => setTimeout(r, 400));
   config.module.rules.pop();

packages/modernjs/src/cli/configPlugin.ts

@@ -353,7 +353,7 @@ export function patchBundlerConfig(options: {
       uniqueName &&
       !chunkFileName.includes(uniqueName)
     ) {
-      const suffix = `${encodeName(uniqueName)}-[chunkhash].js`;
+      const suffix = `${encodeName(uniqueName)}-[contenthash].js`;
       chain.output.chunkFilename(chunkFileName.replace('.js', suffix));
     }
   }

packages/nextjs-mf/src/plugins/NextFederationPlugin/apply-server-plugins.ts

@@ -62,7 +62,7 @@ export function applyServerPlugins(
 ): void {
   const chunkFileName = compiler.options?.output?.chunkFilename;
   const uniqueName = compiler?.options?.output?.uniqueName || options.name;
-  const suffix = `-[chunkhash].js`;
+  const suffix = `-[contenthash].js`;
 
   // Modify chunk filename to include a unique suffix if not already present
   if (

packages/node/README.md

@@ -46,7 +46,7 @@ const { ModuleFederationPlugin } = require('@module-federation/enhanced');
 const options = {
   target: 'async-node',
   output: {
-    chunkFilename: '[id]-[chunkhash].js', // important to hash chunks
+    chunkFilename: '[id]-[contenthash].js', // important to hash chunks
   },
   plugins: [
     new ModuleFederationPlugin({

packages/node/src/plugins/NodeFederationPlugin.ts

@@ -87,7 +87,7 @@ class NodeFederationPlugin {
       uniqueName &&
       !chunkFileName.includes(uniqueName)
     ) {
-      const suffix = `-[chunkhash].js`;
+      const suffix = `-[contenthash].js`;
       compiler.options.output.chunkFilename = chunkFileName.replace(
         '.js',
         suffix,

packages/node/src/plugins/UniversalFederationPlugin.ts

@@ -71,7 +71,7 @@ class UniversalFederationPlugin {
       uniqueName &&
       !chunkFileName.includes(uniqueName)
     ) {
-      const suffix = `-[chunkhash].js`;
+      const suffix = `-[contenthash].js`;
       compiler.options.output.chunkFilename = chunkFileName.replace(
         '.js',
         suffix,

packages/rsbuild-plugin/src/utils/ssr.spec.ts

@@ -138,7 +138,7 @@ describe('patchSSRRspackConfig', () => {
       };
       const patchedConfig = patchSSRRspackConfig(config, mfConfig, 'ssr');
       expect(patchedConfig.output?.chunkFilename).toBe(
-        'js/[name]myApp-[chunkhash].js',
+        'js/[name]myApp-[contenthash].js',
       );
     });
 
@@ -154,7 +154,7 @@ describe('patchSSRRspackConfig', () => {
       const mfConfig: moduleFederationPlugin.ModuleFederationPluginOptions = {}; // No name in mfConfig
       const patchedConfig = patchSSRRspackConfig(config, mfConfig, 'ssr');
       expect(patchedConfig.output?.chunkFilename).toBe(
-        'js/[name]myOutputUniqueName-[chunkhash].js',
+        'js/[name]myOutputUniqueName-[contenthash].js',
       );
     });
 

packages/rsbuild-plugin/src/utils/ssr.ts

@@ -57,7 +57,7 @@ export function patchSSRRspackConfig(
     uniqueName &&
     !chunkFileName.includes(uniqueName)
   ) {
-    const suffix = `${encodeName(uniqueName)}-[chunkhash].js`;
+    const suffix = `${encodeName(uniqueName)}-[contenthash].js`;
     config.output.chunkFilename = chunkFileName.replace('.js', suffix);
   }