Skip to content

Commit 763b9d2

Browse files
feat: add fallback version support for share filtering
- Add fallbackVersion field to include/exclude filters - Implement fallback version checking when primary version detection fails - Add unit and integration tests for fallback version functionality - Update PR plan to clarify share-filter as base branch 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent c1cb7e6 commit 763b9d2

23 files changed

+1075
-518
lines changed

INCREMENTAL_PR_PLAN_REVISED.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ f# Revised Incremental PR Plan for packages/enhanced Changes
33
## Overview
44
Based on a detailed diff analysis, this document provides a more accurate breakdown of changes into focused, incremental PRs. Each PR represents a distinct feature, fix, or refactor that can be merged independently.
55

6+
**IMPORTANT**: All PRs should be compared against the `share-filter` branch as the base branch for measuring changes and creating pull requests.
7+
68
## Updated PR Sequence
79

810
### PR 1: Runtime Safety Fixes
@@ -129,6 +131,8 @@ shared: {
129131
---
130132

131133
### PR 6: Fallback Version Support
134+
**Branch from**: `pr5-request-pattern-filtering`
135+
**Compare against**: `share-filter` branch
132136
**Size**: Small (~6 files)
133137
**Risk**: Low
134138
**Type**: Feature
@@ -141,7 +145,7 @@ shared: {
141145
- Unit tests for fallback version
142146
- Integration tests
143147

144-
**Depends on**: PR 4
148+
**Depends on**: PR 4 and PR 5
145149

146150
**API**:
147151
```javascript

packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,5 +91,4 @@ export interface ConsumesConfig {
9191
request?: string;
9292
exclude?: IncludeExcludeOptions;
9393
include?: IncludeExcludeOptions;
94-
nodeModulesReconstructedLookup?: boolean;
9594
}

packages/enhanced/src/declarations/plugins/sharing/ProvideSharedPlugin.d.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,10 @@ export interface ProvidesConfig {
8484
* Request pattern that must match for the module to be provided.
8585
*/
8686
request?: string | RegExp;
87+
/**
88+
* Fallback version requirement to check if the primary version filter doesn't match.
89+
*/
90+
fallbackVersion?: string;
8791
};
8892
/**
8993
* Exclude filters for providing shared modules.
@@ -97,5 +101,9 @@ export interface ProvidesConfig {
97101
* Request pattern that if matched will exclude the module from being provided.
98102
*/
99103
request?: string | RegExp;
104+
/**
105+
* Fallback version requirement to check if the primary version filter doesn't match.
106+
*/
107+
fallbackVersion?: string;
100108
};
101109
}

0 commit comments

Comments
 (0)