Skip to content

Commit 60d1fc1

Browse files
authored
chore(rsbuild-plugin): revert sharedStrategy default value (#3626)
1 parent 032bff8 commit 60d1fc1

File tree

6 files changed

+22
-3
lines changed

6 files changed

+22
-3
lines changed

.changeset/blue-lizards-happen.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/rsbuild-plugin': patch
3+
---
4+
5+
chore(rsbuild-plugin): revert sharedStrategy default value

apps/website-new/docs/en/guide/troubleshooting/other.mdx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,3 +72,11 @@ new ModuleFederationPlugin({
7272
...
7373
})
7474
```
75+
76+
## HMR failed
77+
78+
* Use [React Developer Tools](https://chromewebstore.google.com/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi)
79+
80+
* If shared is provided from online host, use [Module Federation DevTools](../basic/chrome-devtool), and click `Enable HMR` button .
81+
82+
![](@public/guide/chrome-devtools/mf-devtool-hmr.jpg)
Loading

apps/website-new/docs/zh/guide/troubleshooting/other.mdx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,11 @@ Uncaught TypeError: Cannot read properties on null (reading `useState`)
4646
])
4747
}
4848
```
49+
50+
## HMR 失效
51+
52+
* 使用 [React Developer Tools](https://chromewebstore.google.com/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi)
53+
54+
* 若 shared 提供方是线上的 react ,那么需要使用 [Module Federation DevTools](../basic/chrome-devtool),并点击 `Enable HMR` 按钮
55+
56+
![](@public/guide/chrome-devtools/mf-devtool-hmr.jpg)

packages/create-module-federation/templates/consumer-rsbuild-ts/module-federation.config.ts.handlebars

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ export default createModuleFederationConfig({
55
remotes: {
66
'provider': 'rslib_provider@https://unpkg.com/module-federation-rslib-provider@latest/dist/mf/mf-manifest.json',
77
},
8+
shareStrategy: 'loaded-first',
89
shared: {
910
react: { singleton: true },
1011
'react-dom': { singleton: true },

packages/rsbuild-plugin/src/cli/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,6 @@ export const pluginModuleFederation = (
160160
if (
161161
!bundlerConfig.plugins!.find((p) => p && p.name === PLUGIN_NAME)
162162
) {
163-
if (!moduleFederationOptions.shareStrategy) {
164-
moduleFederationOptions.shareStrategy = 'loaded-first';
165-
}
166163
bundlerConfig.plugins!.push(
167164
new ModuleFederationPlugin(moduleFederationOptions),
168165
);

0 commit comments

Comments
 (0)