Skip to content

Commit d0fcc27

Browse files
committed
various cleanups, among others for better conda / Docker building
1 parent cd60ef0 commit d0fcc27

File tree

4 files changed

+13
-17
lines changed

4 files changed

+13
-17
lines changed

Dockerfile

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,24 @@
1-
FROM continuumio/miniconda3:4.7.12-alpine
1+
FROM continuumio/miniconda3:4.9.2-alpine
22
LABEL maintainer=c.sachs@fz-juelich.de
33

44
USER root
55

66
ENV PATH "$PATH:/opt/conda/bin:/bin/sbin:/usr/bin"
77

8-
# we could copy the files from the current directory, but that would create an additional layer ...
98
COPY . /tmp/package
109

1110
WORKDIR /tmp/package
1211

1312
RUN \
1413
# conda build needs bash
1514
apk add --no-cache bash mesa-gl && \
16-
conda config --add channels conda-forge --add channels bioconda --add channels csachs && \
17-
conda install -y conda-build conda-verify && \
18-
conda build recipe && \
19-
conda install -c local -y molyso && \
20-
conda install -y jupyter pandas && \
15+
conda install -c conda-forge conda-build conda-verify && \
16+
conda build -c conda-forge -c modsim /tmp/package/recipe && \
17+
conda install -c conda-forge -c modsim -c local -y python=3.7 molyso jupyter pandas && \
2118
# missing libGL causes cv2 to fail in a very pecuilar way ... although it just throws an ImportError
2219
# molyso will randomly crash later when importing matplotlib.pyplot
23-
cp -R /tmp/package/examples /examples && \
20+
mv /tmp/package/examples / && \
21+
rm -rf /tmp/package && \
2422
busybox adduser --disabled-password user && \
2523
ln -s /examples /home/user && \
2624
mkdir /data && \
@@ -29,7 +27,7 @@ RUN \
2927
echo "c.NotebookApp.ip = '0.0.0.0'" >> /home/user/.jupyter/jupyter_notebook_config.py && \
3028
echo "c.NotebookApp.notebook_dir = '/home/user'" >> /home/user/.jupyter/jupyter_notebook_config.py && \
3129
conda clean -afy || true && \
32-
conda build purge-all && \
30+
# conda build purge-all && \ # keep the package in the Docker image
3331
echo Done
3432

3533
USER user

README.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ Example:
177177
178178
179179
Supported are among others: the acquisition :code:`interval` (seconds), and the pixel size :code:`calibration` in um per pixel.
180+
Some older files may have incorrectly labeled axes, since molyso expects the time axis to be correctly labeled, it might be necessary to reorder the axes, this can be done on the fly, by passing e.g. :code:`?swap_axes=Z..T`.
180181
Don't forget to escape/quote the ? in the command line.
181182

182183

recipe/meta.yaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% set name = "molyso" %}
2-
{% set version = "1.0.5" %}
3-
{% set sha256 = "02f9cdf1986a848e35b46d6e2ad64cc98c536bdb6fcaf36da6a0902df8a8c1ad" %}
2+
{% set version = "1.0.6" %}
3+
#{% set sha256 = "02f9cdf1986a848e35b46d6e2ad64cc98c536bdb6fcaf36da6a0902df8a8c1ad" %}
44

55
package:
66
name: {{ name|lower }}
@@ -25,9 +25,7 @@ requirements:
2525
- numpy
2626
- scipy
2727
- matplotlib
28-
- tifffile
29-
- nd2file
30-
- czifile
28+
- pilyso-io
3129
- jsonpickle
3230
- tqdm
3331
- opencv

setup.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,9 @@
2828
'License :: OSI Approved :: BSD License',
2929
'Operating System :: POSIX',
3030
'Operating System :: POSIX :: Linux',
31-
'Operating System :: MacOS :: MacOS X', # lately no tests
31+
'Operating System :: MacOS :: MacOS X',
3232
'Operating System :: Microsoft :: Windows',
33-
'Programming Language :: Python :: 3', #
34-
'Programming Language :: Python :: 3.5', # main focus
33+
'Programming Language :: Python :: 3',
3534
'Topic :: Scientific/Engineering :: Bio-Informatics',
3635
'Topic :: Scientific/Engineering :: Image Recognition',
3736
]

0 commit comments

Comments
 (0)