STM32 Timer: connect and configureOutputChannel

[strongly-typed]

connect uses a symbolic template parameter to connect to the pin:

Timer4::connect<GpioB7::Ch2>();

whereas configureOutputChannel uses a plain int for this.

Timer4::configureOutputChannel(2, Timer4::OutputCompareMode::Pwm, 0);

I would love to create a template class that gets GpioB7::Ch2 as a template parameter and then uses this for connect (possible) and deduced the channel number 2 from the template parameter GpioB7::Ch2.

Is there any chance to get something like GpioB7::Ch2::ChId or similar that can be passed to configureOutputChannel?

[chris-durand]

I have made a proof-of-concept on that branch.

With that change you can now also write:

Timer4::configureOutputChannel<GpioB7::Ch2>(Timer4::OutputCompareMode::Pwm, 0);
Timer4::setCompareValue<GpioB7::Ch2>(1000);

This only implements it for those two methods in the general-purpose timer implementation but feel free to take my changes and extend them if you like.

[salkinium]

Nice, though it would have to be for backward compatibility:

Timer4::configureOutputSignal<GpioB7::Ch2>(Timer4::OutputCompareMode::Pwm, 0);
Timer4::setCompareValueSignal<GpioB7::Ch2>(1000);

or alternatively you could also do this less elegant version:

Timer4::configureOutputChannel(Timer4::signalToChannel<GpioB7::Ch2>(), Timer4::OutputCompareMode::Pwm, 0);

[chris-durand]

Nice, though it would have to be for backward compatibility:

Timer4::configureOutputSignal<GpioB7::Ch2>(Timer4::OutputCompareMode::Pwm, 0);
Timer4::setCompareValueSignal<GpioB7::Ch2>(1000);

or alternatively you could also do this less elegant version:

Timer4::configureOutputChannel(Timer4::signalToChannel<GpioB7::Ch2>(), Timer4::OutputCompareMode::Pwm, 0);

I don't see why. The solution I proposed should have zero issues with backward compatibility. You have two overloads of which one is a template taking the signal and the other one isn't.

[salkinium]

Oh, you're right! The number of arguments is different too.

[strongly-typed]

I like the solution. Can we get this merged soon?

[salkinium]

Open a PR and I'll merge it…

[chris-durand]

This solution is mergeable, but not complete. It would be nice if it covered more API functions and also the Advanced Control Timers. All of that could be added later if you need it merged now.

[salkinium]

This feature has been implemented in #912