Skip to content

FEAT: Support pinning objects to a backend #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfc-gh-joshi opened this issue Apr 22, 2025 · 0 comments · Fixed by #7522 or #7546
Closed

FEAT: Support pinning objects to a backend #7521

sfc-gh-joshi opened this issue Apr 22, 2025 · 0 comments · Fixed by #7522 or #7546
Labels
new feature/request 💬 Requests and pull requests for new features

Comments

@sfc-gh-joshi
Copy link
Contributor

When automatic backend switching is enabled, users should be able to opt out via a pin_backend function on inidvidual objects.
@sfc-gh-joshi sfc-gh-joshi added the new feature/request 💬 Requests and pull requests for new features label Apr 22, 2025
sfc-gh-joshi added a commit to sfc-gh-joshi/modin that referenced this issue Apr 22, 2025
@sfc-gh-joshi
FEAT-modin-project#7521: Support pinning objects to a backend
4df32b2 
Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
sfc-gh-joshi added a commit to sfc-gh-joshi/modin that referenced this issue Apr 22, 2025
@sfc-gh-joshi
FEAT-modin-project#7521: Support pinning objects to a backend
c612517 
Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
@sfc-gh-joshi sfc-gh-joshi mentioned this issue Apr 22, 2025
Merged
7 tasks
sfc-gh-joshi added a commit that referenced this issue Apr 30, 2025
@sfc-gh-joshi
FEAT-#7521: Support pinning objects to a backend (#7522)
f953650 
Adds `is_backend_pinned`, `pin_backend`, and `unpin_backend` methods to
the BasePandasDataset, which prevent data from automatically moving to
other backends outside explicit `set_backend` or other materialization
operations. Pinning an object will prevent all subsequent operations
from doing heuristic-based backend switching; a pinned object will
remain pinned until an in-place `unpin_backend` or `set_backend` is
performed. Pinning an object does not prevent materialization for
operations like `__repr__` or `to_pandas()`, which are invoked
explicitly.

Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
sfc-gh-joshi added a commit to sfc-gh-joshi/modin that referenced this issue May 1, 2025
@sfc-gh-joshi
FIX-modin-project#7521: Fix wrong extension being used when backend i…
f39a0f5 
…s pinned

Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
@sfc-gh-joshi sfc-gh-joshi mentioned this issue May 1, 2025
Merged
7 tasks
sfc-gh-joshi added a commit that referenced this issue May 1, 2025
@sfc-gh-joshi
FIX-#7521: Fix wrong extension being used when backend is pinned (#7546)
5c74f0c 
This is a follow-up to #7522, which accidentally broke extension
dispatch when an object is pinned. In the previous PR, the default
method was being used rather than an extension, while the result backend
was correctly preserved.

Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
sfc-gh-jkew pushed a commit that referenced this issue May 4, 2025
@sfc-gh-joshi @sfc-gh-jkew
FIX-#7521: Fix wrong extension being used when backend is pinned (#7546)
15016ca 
This is a follow-up to #7522, which accidentally broke extension
dispatch when an object is pinned. In the previous PR, the default
method was being used rather than an extension, while the result backend
was correctly preserved.

Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature/request 💬 Requests and pull requests for new features
Projects
None yet
Milestone
No milestone
1 participant
@sfc-gh-joshi