feat: Pass window reference to onPopupWindow callback

Author: google-labs-jules[bot]

README.md

@@ -227,7 +227,7 @@ function useMcp(options: UseMcpOptions): UseMcpResult
 | `autoReconnect` | `boolean \| number` | Auto reconnect if an established connection is lost, with delay in ms (default: 3000) |
 | `transportType` | `'auto' \| 'http' \| 'sse'` | Transport type preference: 'auto' (HTTP with SSE fallback), 'http' (HTTP only), 'sse' (SSE only) (default: 'auto') |
 | `preventAutoAuth` | `boolean` | Prevent automatic authentication popup on initial connection (default: false) |
-| `onPopupWindow` | `(url: string, features: string) => void` | Callback invoked just before the authentication popup window is opened |
+| `onPopupWindow` | `(url: string, features: string, window: Window \| null) => void` | Callback invoked just after the authentication popup window is opened |
 
 #### Return Value
 

src/auth/browser-provider.ts

@@ -15,7 +15,7 @@ export class BrowserOAuthClientProvider implements OAuthClientProvider {
   readonly clientName: string
   readonly clientUri: string
   readonly callbackUrl: string
-  readonly onPopupWindow: ((url: string, features: string) => void) | undefined
+  readonly onPopupWindow: ((url: string, features: string, window: Window | null) => void) | undefined
 
   constructor(
     serverUrl: string,
@@ -24,7 +24,7 @@ export class BrowserOAuthClientProvider implements OAuthClientProvider {
       clientName?: string
       clientUri?: string
       callbackUrl?: string
-      onPopupWindow?: (url: string, features: string) => void
+      onPopupWindow?: (url: string, features: string, window: Window | null) => void
     } = {},
   ) {
     this.serverUrl = serverUrl
@@ -170,11 +170,12 @@ export class BrowserOAuthClientProvider implements OAuthClientProvider {
     // Attempt to open the popup
     const popupFeatures = 'width=600,height=700,resizable=yes,scrollbars=yes,status=yes' // Make configurable if needed
     try {
-      // If a callback is provided, invoke it before opening the popup
+      const popup = window.open(sanitizedAuthUrl, `mcp_auth_${this.serverUrlHash}`, popupFeatures)
+
+      // If a callback is provided, invoke it after opening the popup
       if (this.onPopupWindow) {
-        this.onPopupWindow(sanitizedAuthUrl, popupFeatures)
+        this.onPopupWindow(sanitizedAuthUrl, popupFeatures, popup)
       }
-      const popup = window.open(sanitizedAuthUrl, `mcp_auth_${this.serverUrlHash}`, popupFeatures)
 
       if (!popup || popup.closed || typeof popup.closed === 'undefined') {
         console.warn(

src/react/types.ts

@@ -35,7 +35,7 @@ export type UseMcpOptions = {
    * @param url The URL that will be opened in the popup.
    * @param features The features string for the popup window.
    */
-  onPopupWindow?: (url: string, features: string) => void
+  onPopupWindow?: (url: string, features: string, window: Window | null) => void
 }
 
 export type UseMcpResult = {