(fix): Update fallbackRequestHandler type to match _requestHandlers leaves type #784
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only updates type definition
fallbackRequestHandler
current type is not matching the type of what it is a fallback for, i.e. the type of each request handler on theServer
.The following code snippet is the only location where
fallbackRequestHandler
is usedtypescript-sdk/src/shared/protocol.ts
Lines 367 to 368 in 0d54517
Motivation and Context
fallbackRequestHandler
current type lacks the request id, the jsonrpc version (while being actually forwarded) and the extra param altogether. Updating the type avoid having the rely on type casting where fallback must be defined. The new type is exacly the one defined for_requestHandlers
leaves:typescript-sdk/src/shared/protocol.ts
Lines 182 to 188 in 0d54517
How Has This Been Tested?
Locally on my project
Breaking Changes
Non breaking,
JSONRPCRequest
is actually narrower thanRequest
Types of changes
Checklist
Additional context