Skip to content

Commit 5cae11c

Browse files
committed
fix: allow the refresh and revoke token to be handled by the client
1 parent 75ff5f7 commit 5cae11c

File tree

3 files changed

+2
-14
lines changed

3 files changed

+2
-14
lines changed

core/entity/discord.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ func (at *AccessToken) ToHTTPCookies() Cookies {
6161

6262
type RefreshTokenRequest struct {
6363
RefreshToken string `validate:"required"`
64-
Referer string `header:"Referer" validate:"required"`
6564
}
6665

6766
func (rt *RefreshTokenRequest) Validate() error {
@@ -83,7 +82,6 @@ const (
8382
type RevokeTokenRequest struct {
8483
AccessToken string // cookie
8584
RefreshToken string // cookie
86-
Referer string `header:"Referer" validate:"required"`
8785
}
8886

8987
func (rt *RevokeTokenRequest) Validate() error {

handler/http/discord.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ func (d *discordHandler) RefreshToken(c echo.Context) error {
8080
c.SetCookie(cookie)
8181
}
8282

83-
return c.Redirect(http.StatusTemporaryRedirect, req.Referer)
83+
return c.JSON(http.StatusOK, Response{Message: "Token refreshed"})
8484
}
8585

8686
func (d *discordHandler) RevokeToken(c echo.Context) error {
@@ -108,7 +108,7 @@ func (d *discordHandler) RevokeToken(c echo.Context) error {
108108
c.SetCookie(&http.Cookie{Name: key, MaxAge: -1})
109109
}
110110

111-
return c.Redirect(http.StatusTemporaryRedirect, req.Referer)
111+
return c.JSON(http.StatusOK, Response{Message: "Token revoked"})
112112
}
113113

114114
func (d *discordHandler) GetUserByToken(c echo.Context) error {

handler/http/parser.discord.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,6 @@ func parseRefreshTokenRequest(c echo.Context) (*entity.RefreshTokenRequest, erro
4141

4242
req.RefreshToken = refreshTokenCookie.Value
4343

44-
binder := &echo.DefaultBinder{}
45-
if err := binder.BindHeaders(c, req); err != nil {
46-
return nil, fmt.Errorf("%w: %s", entity.ErrorUnauthorized, err)
47-
}
48-
4944
return req, nil
5045
}
5146

@@ -74,11 +69,6 @@ func parseRevokeTokenRequest(c echo.Context) (*entity.RevokeTokenRequest, error)
7469
req.AccessToken = accessTokenCookie.Value
7570
}
7671

77-
binder := &echo.DefaultBinder{}
78-
if err := binder.BindHeaders(c, req); err != nil {
79-
return nil, fmt.Errorf("%w: %s", entity.ErrorUnauthorized, err)
80-
}
81-
8272
return req, nil
8373
}
8474

0 commit comments

Comments
 (0)