Skip to content

Commit 13fe70d

Browse files
committed
feat: allow is logged in to be https cookie
1 parent 3e49b7e commit 13fe70d

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

core/entity/discord.go

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,27 +33,31 @@ func (at *AccessToken) ToHTTPCookies() Cookies {
3333
refreshTokenMaxAge := at.ExpiresIn + int(OAuthRefreshTokenMaxAge.Seconds())
3434

3535
accessTokenCookie := &http.Cookie{
36-
Name: cookiey.CookieAccessToken,
37-
Value: at.AccessToken,
38-
MaxAge: at.ExpiresIn,
36+
Name: cookiey.CookieAccessToken,
37+
Value: at.AccessToken,
38+
MaxAge: at.ExpiresIn,
39+
HttpOnly: true,
3940
}
4041

4142
refreshTokenCookie := &http.Cookie{
42-
Name: cookiey.CookieRefreshToken,
43-
Value: at.RefreshToken,
44-
MaxAge: refreshTokenMaxAge,
43+
Name: cookiey.CookieRefreshToken,
44+
Value: at.RefreshToken,
45+
MaxAge: refreshTokenMaxAge,
46+
HttpOnly: true,
4547
}
4648

4749
tokenTypeCookie := &http.Cookie{
48-
Name: cookiey.CookieTokenType,
49-
Value: at.TokenType,
50-
MaxAge: at.ExpiresIn,
50+
Name: cookiey.CookieTokenType,
51+
Value: at.TokenType,
52+
MaxAge: at.ExpiresIn,
53+
HttpOnly: true,
5154
}
5255

5356
scopeCookie := &http.Cookie{
54-
Name: cookiey.CookieScope,
55-
Value: at.Scope,
56-
MaxAge: at.ExpiresIn,
57+
Name: cookiey.CookieScope,
58+
Value: at.Scope,
59+
MaxAge: at.ExpiresIn,
60+
HttpOnly: true,
5761
}
5862

5963
isLoggedInCookie := &http.Cookie{

handler/http/discord.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ func (d *discordHandler) OauthCallback(c echo.Context) error {
4747
cookie.Secure = !isLocalhost
4848
cookie.Domain = d.cfg.Discord.RedirectDomain
4949
cookie.Path = "/"
50-
cookie.HttpOnly = true
5150
cookie.SameSite = http.SameSiteLaxMode
5251

5352
c.SetCookie(cookie)
@@ -75,7 +74,6 @@ func (d *discordHandler) RefreshToken(c echo.Context) error {
7574
cookie.Secure = !isLocalhost
7675
cookie.Domain = d.cfg.Discord.RedirectDomain
7776
cookie.Path = "/"
78-
cookie.HttpOnly = true
7977
cookie.SameSite = http.SameSiteLaxMode
8078

8179
c.SetCookie(cookie)

0 commit comments

Comments
 (0)