fix: Error shows on flow runs "Failed to reach out XCUITest Server" (#986)

artem888 · web-flow · commit 7d687753ea30 · 2023-04-12T16:18:10.000+02:00
return an error response instead of throwing custom exception for OkHttpClient networkInterceptor
diff --git a/maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt b/maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt
@@ -226,7 +226,11 @@ class XCTestDriverClient(
                     .code(200)
                     .build()
             } else {
-                throw XCTestDriverUnreachable("Failed to reach out XCUITest Server in ReturnOkOnShutdown")
+                Response.Builder()
+                    .request(it.request())
+                    .protocol(Protocol.HTTP_1_1)
+                    .code(400)
+                    .build()
             }
         }
     })

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,11 @@ class XCTestDriverClient(`
`226`	`226`	`.code(200)`
`227`	`227`	`.build()`
`228`	`228`	`} else {`
`229`		`- throw XCTestDriverUnreachable("Failed to reach out XCUITest Server in ReturnOkOnShutdown")`
	`229`	`+ Response.Builder()`
	`230`	`+ .request(it.request())`
	`231`	`+ .protocol(Protocol.HTTP_1_1)`
	`232`	`+ .code(400)`
	`233`	`+ .build()`
`230`	`234`	`}`
`231`	`235`	`}`
`232`	`236`	`})`