Skip to content

Commit 98b313e

Browse files
committed
Commenting out build-debug-regen-ffi and check-ffi tests
1 parent 77cb350 commit 98b313e

File tree

1 file changed

+45
-44
lines changed

1 file changed

+45
-44
lines changed

.github/workflows/binding-tests.yml

Lines changed: 45 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -39,51 +39,52 @@ jobs:
3939
run: |
4040
./.github/scripts/ci-style.sh
4141
42-
build-debug-regen-ffi:
43-
runs-on: ubuntu-22.04
44-
steps:
45-
- uses: actions/checkout@v2
46-
- name: Setup environments
47-
run: |
48-
./.github/scripts/ci-checkout.sh ${{ inputs.julia_repo }} ${{ inputs.julia_ref }}
49-
./.github/scripts/ci-setup.sh
50-
# removing these as they cause a conflict within bindgen
51-
sudo rm -rf /usr/lib/llvm-14
52-
sudo rm -rf /usr/lib/llvm-13
53-
- name: Check FFI bindings
54-
run: |
55-
./.github/scripts/ci-ffi.sh
56-
- name: Build Julia (Debug)
57-
run: |
58-
./.github/scripts/ci-build.sh debug ${{ inputs.gc_plan }} ${{ inputs.moving }}
59-
- name: Print Julia version info
60-
run: |
61-
JULIA_PATH=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia/vm/julia
62-
$JULIA_PATH/julia --project=. -e "using InteractiveUtils; versioninfo()"
63-
- name: Style check
64-
run: |
65-
./.github/scripts/ci-style.sh
42+
# Commenting these out since they shouldn't be needed in the mmtk-support-moving-upstream branch
43+
# build-debug-regen-ffi:
44+
# runs-on: ubuntu-22.04
45+
# steps:
46+
# - uses: actions/checkout@v2
47+
# - name: Setup environments
48+
# run: |
49+
# ./.github/scripts/ci-checkout.sh ${{ inputs.julia_repo }} ${{ inputs.julia_ref }}
50+
# ./.github/scripts/ci-setup.sh
51+
# # removing these as they cause a conflict within bindgen
52+
# sudo rm -rf /usr/lib/llvm-14
53+
# sudo rm -rf /usr/lib/llvm-13
54+
# - name: Check FFI bindings
55+
# run: |
56+
# ./.github/scripts/ci-ffi.sh
57+
# - name: Build Julia (Debug)
58+
# run: |
59+
# ./.github/scripts/ci-build.sh debug ${{ inputs.gc_plan }} ${{ inputs.moving }}
60+
# - name: Print Julia version info
61+
# run: |
62+
# JULIA_PATH=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia/vm/julia
63+
# $JULIA_PATH/julia --project=. -e "using InteractiveUtils; versioninfo()"
64+
# - name: Style check
65+
# run: |
66+
# ./.github/scripts/ci-style.sh
6667

67-
check-ffi:
68-
runs-on: ubuntu-22.04
69-
steps:
70-
- uses: actions/checkout@v2
71-
- name: Setup environments
72-
run: |
73-
./.github/scripts/ci-checkout.sh ${{ inputs.julia_repo }} ${{ inputs.julia_ref }}
74-
./.github/scripts/ci-setup.sh
75-
# removing these as they cause a conflict within bindgen
76-
sudo rm -rf /usr/lib/llvm-14
77-
sudo rm -rf /usr/lib/llvm-13
78-
- name: Regenerate FFI bindings
79-
run: |
80-
./.github/scripts/ci-ffi.sh
81-
- run: |
82-
MMTK_JULIA_DIR=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia
83-
if ! git diff --exit-code $MMTK_JULIA_DIR/mmtk/src/julia_types.rs; then
84-
echo "Rust FFI bindings in \`julia_types.rs\` are outdated. Run \`make regen-bindgen-ffi\` from the mmtk-julia directory and make sure to include the updated file in the pull request."
85-
exit 1
86-
fi
68+
# check-ffi:
69+
# runs-on: ubuntu-22.04
70+
# steps:
71+
# - uses: actions/checkout@v2
72+
# - name: Setup environments
73+
# run: |
74+
# ./.github/scripts/ci-checkout.sh ${{ inputs.julia_repo }} ${{ inputs.julia_ref }}
75+
# ./.github/scripts/ci-setup.sh
76+
# # removing these as they cause a conflict within bindgen
77+
# sudo rm -rf /usr/lib/llvm-14
78+
# sudo rm -rf /usr/lib/llvm-13
79+
# - name: Regenerate FFI bindings
80+
# run: |
81+
# ./.github/scripts/ci-ffi.sh
82+
# - run: |
83+
# MMTK_JULIA_DIR=$(realpath $(dirname "$0"))/../mmtk-julia/mmtk-julia
84+
# if ! git diff --exit-code $MMTK_JULIA_DIR/mmtk/src/julia_types.rs; then
85+
# echo "Rust FFI bindings in \`julia_types.rs\` are outdated. Run \`make regen-bindgen-ffi\` from the mmtk-julia directory and make sure to include the updated file in the pull request."
86+
# exit 1
87+
# fi
8788

8889
build-test-other:
8990
runs-on: ubuntu-22.04

0 commit comments

Comments
 (0)