Skip to content

Commit df7a1f1

Browse files
authored
Remove V8 tests from extended tests (#1313)
This PR removes V8 tests from our extended tests for mmtk-core. The V8 version we use in the binding is outdated, and the required environments are no longer supported by Github runners. See the discussion in [#ANU Research > The V8 binding is beyond repair @ 💬](https://mmtk.zulipchat.com/#narrow/channel/262677-ANU-Research/topic/The.20V8.20binding.20is.20beyond.20repair/near/509115086).
1 parent f5179fb commit df7a1f1

File tree

1 file changed

+42
-36
lines changed

1 file changed

+42
-36
lines changed

.github/workflows/extended-tests-bindings.yml

Lines changed: 42 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -19,42 +19,48 @@ jobs:
1919
with:
2020
pull_request: ${{ github.event.pull_request.number }}
2121

22-
extended-tests-v8:
23-
runs-on: ubuntu-20.04
24-
needs: binding-refs
25-
if: contains(github.event.pull_request.labels.*.name, 'PR-extended-testing')
26-
steps:
27-
- name: Checkout MMTk Core
28-
uses: actions/checkout@v4
29-
with:
30-
path: mmtk-core
31-
- name: Checkout V8 Binding
32-
uses: actions/checkout@v4
33-
with:
34-
repository: ${{ needs.binding-refs.outputs.v8_binding_repo }}
35-
path: mmtk-v8
36-
ref: ${{ needs.binding-refs.outputs.v8_binding_ref }}
37-
- name: Use mmtk-core Rust toolchain for bindings
38-
run: |
39-
cp mmtk-core/rust-toolchain mmtk-v8/mmtk
40-
- name: Overwrite MMTk core in V8 binding
41-
run: |
42-
rm -rf mmtk-v8/repos/*
43-
mkdir -p mmtk-v8/repos/mmtk-core
44-
cp -r mmtk-core/* mmtk-v8/repos/mmtk-core
45-
- name: Setup
46-
run: |
47-
cd mmtk-v8
48-
./.github/scripts/ci-setup.sh
49-
sed -i 's/^mmtk[[:space:]]=/#ci:mmtk=/g' mmtk/Cargo.toml
50-
sed -i 's/^#[[:space:]]mmtk/mmtk/g' mmtk/Cargo.toml
51-
- name: Test
52-
run: |
53-
cd mmtk-v8
54-
export RUST_BACKTRACE=1
55-
export V8_ROOT=$GITHUB_WORKSPACE/v8_deps
56-
.github/scripts/ci-test.sh
57-
.github/scripts/ci-style.sh
22+
# Our V8 version is too old, and the required environments are no longer supported.
23+
# Disable the tests for now, until we plan to upgrade the V8 version and get it working again.
24+
# See: https://mmtk.zulipchat.com/#narrow/channel/262677-ANU-Research/topic/The.20V8.20binding.20is.20beyond.20repair/near/509115086
25+
# > After fixing some CI scripts issues, I find that some of the bundled Python code in V8 is depending on Python2,
26+
# > which has reached EOL long ago, and will no longer be available on Ubuntu 24.04. Ubuntu 22.04 has Python 3 as the default
27+
# > python executable, which causes the error on the CI. Ubuntu 20.04 will be unsupported the next month, so we can't keep using it.
28+
# extended-tests-v8:
29+
# runs-on: ubuntu-20.04
30+
# needs: binding-refs
31+
# if: contains(github.event.pull_request.labels.*.name, 'PR-extended-testing')
32+
# steps:
33+
# - name: Checkout MMTk Core
34+
# uses: actions/checkout@v4
35+
# with:
36+
# path: mmtk-core
37+
# - name: Checkout V8 Binding
38+
# uses: actions/checkout@v4
39+
# with:
40+
# repository: ${{ needs.binding-refs.outputs.v8_binding_repo }}
41+
# path: mmtk-v8
42+
# ref: ${{ needs.binding-refs.outputs.v8_binding_ref }}
43+
# - name: Use mmtk-core Rust toolchain for bindings
44+
# run: |
45+
# cp mmtk-core/rust-toolchain mmtk-v8/mmtk
46+
# - name: Overwrite MMTk core in V8 binding
47+
# run: |
48+
# rm -rf mmtk-v8/repos/*
49+
# mkdir -p mmtk-v8/repos/mmtk-core
50+
# cp -r mmtk-core/* mmtk-v8/repos/mmtk-core
51+
# - name: Setup
52+
# run: |
53+
# cd mmtk-v8
54+
# ./.github/scripts/ci-setup.sh
55+
# sed -i 's/^mmtk[[:space:]]=/#ci:mmtk=/g' mmtk/Cargo.toml
56+
# sed -i 's/^#[[:space:]]mmtk/mmtk/g' mmtk/Cargo.toml
57+
# - name: Test
58+
# run: |
59+
# cd mmtk-v8
60+
# export RUST_BACKTRACE=1
61+
# export V8_ROOT=$GITHUB_WORKSPACE/v8_deps
62+
# .github/scripts/ci-test.sh
63+
# .github/scripts/ci-style.sh
5864

5965
extended-tests-openjdk:
6066
needs: binding-refs

0 commit comments

Comments
 (0)