Skip to content

Commit da9fb1f

Browse files
authored
Use ci-perf-kit 0.7.4: ignore runs with unmatched key/value in the logs. (#1025)
The perf CI run for mutator performance recently failed for the following error: ```console ++ python3 scripts/mutator_report.py /home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/ci-perf-kit/result_repo/mutator /home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/reports/master Traceback (most recent call last): File "/home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/ci-perf-kit/scripts/mutator_report.py", line 43, in <module> run_id, results = parse.parse_run(os.path.join(result_repo_mutator_root, l)) File "/home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/ci-perf-kit/scripts/parse.py", line 82, in parse_run results.append(parse_log(os.path.join(log_folder, l), n_invocations)) File "/home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/ci-perf-kit/scripts/parse.py", line 48, in parse_log assert len(mmtk_keys) == len(mmtk_values), "Error when reading MMTk statistics: num of keys does not match num of values" AssertionError: Error when reading MMTk statistics: num of keys does not match num of values ``` One of the runs recently has an incomplete `MMTk Statistics` printing. The process quit for some reason before it prints the values. This seems to be a random issue, as the other runs in the same log file look fine. ```console ============================ MMTk Statistics Totals ============================ GC time.other time.stw time.jitc time.ygc collections.young time.ogc collections.old ``` The unmatched key/value pairs caused an assertion failure in the `ci-perf-kit` script.`ci-perf-kit 0.7.4` (https://github.com/mmtk/ci-perf-kit/releases/tag/0.7.4) fixes this. Runs that do not have valid key/value pairs will be ignored, and the script will not quit.
1 parent 2d5bae7 commit da9fb1f

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.github/workflows/micro-bm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
with:
6767
repository: mmtk/ci-perf-kit
6868
token: ${{ secrets.GITHUB_TOKEN }}
69-
ref: "0.7.3"
69+
ref: "0.7.4"
7070
path: ci-perf-kit
7171
submodules: true
7272
# Use rust-toolchain in the trunk (it doesnt matter much - if the toolchains defined in the trunk and the branch are different, we cant run anyway)

.github/workflows/perf-baseline.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
with:
4343
token: ${{ secrets.CI_ACCESS_TOKEN }}
4444
repository: mmtk/ci-perf-kit
45-
ref: "0.7.3"
45+
ref: "0.7.4"
4646
path: ci-perf-kit
4747
submodules: true
4848
# setup
@@ -94,7 +94,7 @@ jobs:
9494
with:
9595
token: ${{ secrets.CI_ACCESS_TOKEN }}
9696
repository: mmtk/ci-perf-kit
97-
ref: "0.7.3"
97+
ref: "0.7.4"
9898
path: ci-perf-kit
9999
submodules: true
100100
# setup

.github/workflows/perf-compare-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
with:
113113
repository: mmtk/ci-perf-kit
114114
token: ${{ secrets.CI_ACCESS_TOKEN }}
115-
ref: "0.7.3"
115+
ref: "0.7.4"
116116
path: ci-perf-kit
117117
submodules: true
118118
# setup
@@ -219,7 +219,7 @@ jobs:
219219
with:
220220
repository: mmtk/ci-perf-kit
221221
token: ${{ secrets.CI_ACCESS_TOKEN }}
222-
ref: "0.7.3"
222+
ref: "0.7.4"
223223
path: ci-perf-kit
224224
submodules: true
225225
# setup

.github/workflows/perf-regression-ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
uses: actions/checkout@v2
4646
with:
4747
repository: mmtk/ci-perf-kit
48-
ref: "0.7.3"
48+
ref: "0.7.4"
4949
path: ci-perf-kit
5050
token: ${{ secrets.CI_ACCESS_TOKEN }}
5151
submodules: true
@@ -116,7 +116,7 @@ jobs:
116116
uses: actions/checkout@v2
117117
with:
118118
repository: mmtk/ci-perf-kit
119-
ref: "0.7.3"
119+
ref: "0.7.4"
120120
path: ci-perf-kit
121121
token: ${{ secrets.CI_ACCESS_TOKEN }}
122122
submodules: true
@@ -191,7 +191,7 @@ jobs:
191191
uses: actions/checkout@v2
192192
with:
193193
repository: mmtk/ci-perf-kit
194-
ref: "0.7.3"
194+
ref: "0.7.4"
195195
path: ci-perf-kit
196196
token: ${{ secrets.CI_ACCESS_TOKEN }}
197197
submodules: true

0 commit comments

Comments
 (0)