Skip to content

Commit d253d97

Browse files
authored
Fix multiple issues in recent CI changes (#1014)
There are some issues with the recent CI changes. This PR bumps ci-perf-kit to 0.7.2, which fixes some of them, and separate issues are created for the issue(s) that is not fixed in the PR. * ci-perf-kit 0.7.1 allows drawing notes on the graph to show the date where there are known CI environment changes. But it has some issues: * Each note is by mistake plotted only once for all the graphs (which means only one graph will have the note). In the Python script, we should copy the note list before processing it. * In the case that there is only one run for several notes. (e.g. we have notes on 1101 and 1102, and we have runs on 1103 and 1104. Both notes for 1101 and 1102 should show on the data point for 1103. The current CI plots one note on 1103 and one note on 1104. We should combine the notes on 1101 and 1102, and plot them for the run 1103. * 0.7.1 sets the heap size to 8g (for OpenJDK NoGC runs, and mutator runs), but by mistake uses a modifier `heap30g`. This causes confusion. It should be name as `heap8g`. * 0.7.1 by mistake sets the plan to `gencopy` in a GenImmix config. ci-perf-kit 0.7.2 (https://github.com/mmtk/ci-perf-kit/releases/tag/0.7.2) fixes those issues.
1 parent 650eea8 commit d253d97

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.github/workflows/micro-bm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
with:
6767
repository: mmtk/ci-perf-kit
6868
token: ${{ secrets.GITHUB_TOKEN }}
69-
ref: "0.7.1"
69+
ref: "0.7.2"
7070
path: ci-perf-kit
7171
submodules: true
7272
# Use rust-toolchain in the trunk (it doesnt matter much - if the toolchains defined in the trunk and the branch are different, we cant run anyway)

.github/workflows/perf-baseline.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
with:
4343
token: ${{ secrets.CI_ACCESS_TOKEN }}
4444
repository: mmtk/ci-perf-kit
45-
ref: "0.7.1"
45+
ref: "0.7.2"
4646
path: ci-perf-kit
4747
submodules: true
4848
# setup
@@ -94,7 +94,7 @@ jobs:
9494
with:
9595
token: ${{ secrets.CI_ACCESS_TOKEN }}
9696
repository: mmtk/ci-perf-kit
97-
ref: "0.7.1"
97+
ref: "0.7.2"
9898
path: ci-perf-kit
9999
submodules: true
100100
# setup

.github/workflows/perf-compare-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
with:
113113
repository: mmtk/ci-perf-kit
114114
token: ${{ secrets.CI_ACCESS_TOKEN }}
115-
ref: "0.7.1"
115+
ref: "0.7.2"
116116
path: ci-perf-kit
117117
submodules: true
118118
# setup
@@ -219,7 +219,7 @@ jobs:
219219
with:
220220
repository: mmtk/ci-perf-kit
221221
token: ${{ secrets.CI_ACCESS_TOKEN }}
222-
ref: "0.7.1"
222+
ref: "0.7.2"
223223
path: ci-perf-kit
224224
submodules: true
225225
# setup

.github/workflows/perf-regression-ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
uses: actions/checkout@v2
4646
with:
4747
repository: mmtk/ci-perf-kit
48-
ref: "0.7.1"
48+
ref: "0.7.2"
4949
path: ci-perf-kit
5050
token: ${{ secrets.CI_ACCESS_TOKEN }}
5151
submodules: true
@@ -116,7 +116,7 @@ jobs:
116116
uses: actions/checkout@v2
117117
with:
118118
repository: mmtk/ci-perf-kit
119-
ref: "0.7.1"
119+
ref: "0.7.2"
120120
path: ci-perf-kit
121121
token: ${{ secrets.CI_ACCESS_TOKEN }}
122122
submodules: true
@@ -191,7 +191,7 @@ jobs:
191191
uses: actions/checkout@v2
192192
with:
193193
repository: mmtk/ci-perf-kit
194-
ref: "0.7.1"
194+
ref: "0.7.2"
195195
path: ci-perf-kit
196196
token: ${{ secrets.CI_ACCESS_TOKEN }}
197197
submodules: true

0 commit comments

Comments
 (0)