Skip to content

Commit 1200476

Browse files
authored
drop ubuntu-20.04 in GHA (#55)
* drop ubuntu-20.04 in GHA * setup dependencies on ubuntu 20.04 * update? * Node 23 is not legacy
1 parent 46df27f commit 1200476

File tree

2 files changed

+41
-9
lines changed

2 files changed

+41
-9
lines changed

.github/workflows/test-dev.yml

Lines changed: 40 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,14 @@ on:
1111
- '*.md'
1212

1313
jobs:
14-
release:
14+
default:
1515
runs-on: ${{ matrix.platform }}
1616

1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
platform: [ubuntu-latest, ubuntu-20.04, windows-2019, windows-2022, macos-latest]
20+
platform: [ubuntu-latest, ubuntu-22.04, windows-2019, windows-2022, macos-latest]
2121
node-version: ['18.17', 18, 20, 22, 23]
22-
exclude:
23-
- platform: ubuntu-20.04
24-
node-version: 23
2522

2623
steps:
2724
- uses: actions/checkout@v3
@@ -46,6 +43,44 @@ jobs:
4643
shell: bash
4744

4845

46+
legacy:
47+
runs-on: ubuntu-latest
48+
container: ubuntu:20.04
49+
50+
strategy:
51+
fail-fast: false
52+
matrix:
53+
node-version: ['18.17', 18, 20, 22]
54+
55+
steps:
56+
- uses: actions/checkout@v3
57+
- name: Use Node.js ${{ matrix.node-version }}
58+
uses: actions/setup-node@v3
59+
with:
60+
node-version: ${{ matrix.node-version }}
61+
- name: Setup dependencies
62+
run: |
63+
apt-get update
64+
apt-get -y install python3 g++ make
65+
env:
66+
DEBIAN_FRONTEND: noninteractive
67+
- run: npm install
68+
- run: npm test
69+
- name: Link the package
70+
run: npm link
71+
- name: Check the example
72+
run: |
73+
cd example
74+
npm install --ignore-scripts
75+
npm link nobind17
76+
npx node-gyp configure build --debug
77+
node -p "require('./lib/hello.node').hello('Garga')"
78+
npx node-gyp configure build
79+
node -p "require('./lib/hello.node').hello('Garga')"
80+
npx tsx hello.ts
81+
shell: bash
82+
83+
4984
options:
5085
runs-on: ${{ matrix.platform }}
5186

.github/workflows/test-npm.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
platform: [ubuntu-20.04, ubuntu-24.04, windows-2019, macos-13, macos-15]
17+
platform: [ubuntu-22.04, ubuntu-24.04, windows-2019, macos-13, macos-15]
1818
node-version: ['18.17', 18, 20, 22, 23]
19-
exclude:
20-
- platform: ubuntu-20.04
21-
node-version: 23
2219

2320
steps:
2421
- uses: actions/checkout@v3

0 commit comments

Comments
 (0)