max width and height set with jekyll picture tag #3963
Unanswered
mkruisbrink
asked this question in
Q&A
Replies: 1 comment
-
Resolved. JPT not supported by GH pages as whitelisted plugin so the site didn't build and deploy properly anyway. The only way I was able to use the plugin was to add a custom workflow. Also posted this in the discussion board of the plugin itself and the maintainer said he'd look into it. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Thanks for the amazing theme, got it working on two sites now and learning amazing stuff everyday through struggling forward :)
I've been trying to serve images responsively with Jekyll Picture Tag. I know this plugin isn't whitelisted for GitHub pages and I'm also aware that the theme forum is perhaps not the right place to ask questions but perhaps someone has the experience.
I've come across this topic on JPT for the theme but this didn't cover the CLS topic specifically
I'm now properly serving responsive
.webp
images on my about page but I can't seem to figure out how to properly set thewidth
andheight
element for the images to make Lighthouse (and myself) proper happy._base.scss
adjustments by switching thewidth: 100%
toauto
though I'm not quite sure this would be the proper location since below snippet bothwidth
andheight
are set on auto._reset.scss
:The images are served responsively when inspecting in dev tools and I also see
_base.scss
and_reset.scss
applied. Somehow the functionality to reduce the CLS by specifyingwidth
andheight
parameters is not working for me.Could anyone point me towards what I might be doing wrong? Thanks in advance!
Beta Was this translation helpful? Give feedback.
All reactions