You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been testing v2.7.3 and I think that, given that urlparse works perfectly, tld is not needed and therefore should be removed. It doesn't make any sense to have a third party lib when native python job does the trick, even as an option.
Therefore, I propose removing the SECTIONS_BY_DOMAIN_USING_TLD flag and always use urlparse.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Hi there @mmagnus
I've been testing v2.7.3 and I think that, given that urlparse works perfectly, tld is not needed and therefore should be removed. It doesn't make any sense to have a third party lib when native python job does the trick, even as an option.
Therefore, I propose removing the SECTIONS_BY_DOMAIN_USING_TLD flag and always use urlparse.
Regards
Beta Was this translation helpful? Give feedback.
All reactions