From 592dbe915aec353cc350dedc041ba3b3f3420a5c Mon Sep 17 00:00:00 2001 From: be-marc Date: Thu, 10 Jul 2025 09:50:01 +0200 Subject: [PATCH 1/3] ci: fail on note --- .github/workflows/dev-cmd-check.yml | 9 ++-- .github/workflows/no-suggest-cmd-check.yml | 63 ++++++++++++++++++++++ .github/workflows/r-cmd-check.yml | 5 +- 3 files changed, 72 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/no-suggest-cmd-check.yml diff --git a/.github/workflows/dev-cmd-check.yml b/.github/workflows/dev-cmd-check.yml index ec46f1b6..a3270049 100644 --- a/.github/workflows/dev-cmd-check.yml +++ b/.github/workflows/dev-cmd-check.yml @@ -1,5 +1,6 @@ -# dev cmd check workflow of the mlr3 ecosystem v0.3.1 +# dev cmd check workflow of the mlr3 ecosystem v0.4.0 # https://github.com/mlr-org/actions +# modified to use supercharge/redis-github-action@1.7.0 on: workflow_dispatch: inputs: @@ -32,6 +33,7 @@ jobs: config: - {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/bbotk'} - {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3'} + - {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3misc'} steps: - uses: actions/checkout@v3 @@ -50,11 +52,12 @@ jobs: with: extra-packages: any::rcmdcheck needs: check + error-on: '"note"' - name: Install dev versions - run: pak::pkg_install(c('${{ matrix.config.dev-package }}')) + run: pak::pkg_install('${{ matrix.config.dev-package }}') shell: Rscript {0} - + - uses: mxschmitt/action-tmate@v3 if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }} with: diff --git a/.github/workflows/no-suggest-cmd-check.yml b/.github/workflows/no-suggest-cmd-check.yml new file mode 100644 index 00000000..fd077554 --- /dev/null +++ b/.github/workflows/no-suggest-cmd-check.yml @@ -0,0 +1,63 @@ +# r cmd check workflow without suggests of the mlr3 ecosystem v0.1.0 +# https://github.com/mlr-org/actions +# modified to use supercharge/redis-github-action@1.7.0 +on: + workflow_dispatch: + inputs: + debug_enabled: + type: boolean + description: 'Run the build with tmate debugging enabled' + required: false + default: false + push: + branches: + - main + pull_request: + branches: + - main + +name: no-suggest-cmd-check + +jobs: + no-suggest-cmd-check: + runs-on: ${{ matrix.config.os }} + + name: ${{ matrix.config.os }} (${{ matrix.config.r }}) + + env: + GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} + + strategy: + fail-fast: false + matrix: + config: + - {os: ubuntu-latest, r: 'release'} + + steps: + - uses: actions/checkout@v3 + + - uses: r-lib/actions/setup-pandoc@v2 + + - uses: r-lib/actions/setup-r@v2 + with: + r-version: ${{ matrix.config.r }} + + - uses: supercharge/redis-github-action@1.7.0 + with: + redis-version: 7 + + - uses: r-lib/actions/setup-r-dependencies@v2 + with: + extra-packages: any::rcmdcheck + needs: check + error-on: '"note"' + dependencies: '"hard"' + + - uses: mxschmitt/action-tmate@v3 + if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }} + with: + limit-access-to-actor: true + + - uses: r-lib/actions/check-r-package@v2 + with: + args: 'c("--no-manual", "--as-cran")' diff --git a/.github/workflows/r-cmd-check.yml b/.github/workflows/r-cmd-check.yml index 597f70ba..846ade0a 100644 --- a/.github/workflows/r-cmd-check.yml +++ b/.github/workflows/r-cmd-check.yml @@ -1,5 +1,6 @@ -# r cmd check workflow of the mlr3 ecosystem v0.3.1 +# r cmd check workflow of the mlr3 ecosystem v0.4.0 # https://github.com/mlr-org/actions +# modified to use supercharge/redis-github-action@1.7.0 on: workflow_dispatch: inputs: @@ -50,6 +51,7 @@ jobs: with: extra-packages: any::rcmdcheck needs: check + error-on: '"note"' - uses: mxschmitt/action-tmate@v3 if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }} @@ -59,4 +61,3 @@ jobs: - uses: r-lib/actions/check-r-package@v2 with: args: 'c("--no-manual", "--as-cran")' - From 05b36580a20abc6b3ac13a66f41b4ba53ff8623e Mon Sep 17 00:00:00 2001 From: be-marc Date: Thu, 10 Jul 2025 09:53:24 +0200 Subject: [PATCH 2/3] ... --- .github/workflows/dev-cmd-check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dev-cmd-check.yml b/.github/workflows/dev-cmd-check.yml index a3270049..4597dfb2 100644 --- a/.github/workflows/dev-cmd-check.yml +++ b/.github/workflows/dev-cmd-check.yml @@ -34,6 +34,7 @@ jobs: - {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/bbotk'} - {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3'} - {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3misc'} + - {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/paradox'} steps: - uses: actions/checkout@v3 @@ -57,7 +58,7 @@ jobs: - name: Install dev versions run: pak::pkg_install('${{ matrix.config.dev-package }}') shell: Rscript {0} - + - uses: mxschmitt/action-tmate@v3 if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }} with: From e324fe1d6f2910bf87a498b0debbc1126513038c Mon Sep 17 00:00:00 2001 From: be-marc Date: Thu, 10 Jul 2025 10:11:30 +0200 Subject: [PATCH 3/3] ... --- R/EnsembleFSResult.R | 1 + man/ensemble_fs_result.Rd | 2 ++ man/mlr_fselectors_async_random_search.Rd | 5 ----- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/R/EnsembleFSResult.R b/R/EnsembleFSResult.R index 4b52382c..ab0723ee 100644 --- a/R/EnsembleFSResult.R +++ b/R/EnsembleFSResult.R @@ -23,6 +23,7 @@ #' `r format_bib("das1999", "meinshausen2010")` #' #' @export +#' @examplesIf mlr3misc::require_namespaces("fastVoteR", quietly = TRUE) #' @examples #' \donttest{ #' efsr = ensemble_fselect( diff --git a/man/ensemble_fs_result.Rd b/man/ensemble_fs_result.Rd index e5ae6e2a..45f6911c 100644 --- a/man/ensemble_fs_result.Rd +++ b/man/ensemble_fs_result.Rd @@ -28,6 +28,8 @@ Combines multiple \link{EnsembleFSResult} objects into a new \link{EnsembleFSRes } \examples{ +\dontshow{if (mlr3misc::require_namespaces("fastVoteR", quietly = TRUE)) (if (getRversion() >= "3.4") withAutoprint else force)(\{ # examplesIf} +\dontshow{\}) # examplesIf} \donttest{ efsr = ensemble_fselect( fselector = fs("rfe", n_features = 2, feature_fraction = 0.8), diff --git a/man/mlr_fselectors_async_random_search.Rd b/man/mlr_fselectors_async_random_search.Rd index c67a7f7f..3fde6cfd 100644 --- a/man/mlr_fselectors_async_random_search.Rd +++ b/man/mlr_fselectors_async_random_search.Rd @@ -13,11 +13,6 @@ Bergstra J, Bengio Y (2012). \description{ Feature selection using Asynchronous Random Search Algorithm. } -\details{ -The feature sets are randomly drawn. -The sets are evaluated asynchronously. -The algorithm uses \link[bbotk:mlr_optimizers_async_random_search]{bbotk::OptimizerAsyncRandomSearch} for optimization. -} \section{Dictionary}{ This \link{FSelector} can be instantiated with the associated sugar function \code{\link[=fs]{fs()}}: