Skip to content

Commit 4baa835

Browse files
authored
ci: fail on note (#140)
* ci: fail on note * ... * ...
1 parent 4ead0e6 commit 4baa835

File tree

6 files changed

+75
-9
lines changed

6 files changed

+75
-9
lines changed

.github/workflows/dev-cmd-check.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
# dev cmd check workflow of the mlr3 ecosystem v0.3.1
1+
# dev cmd check workflow of the mlr3 ecosystem v0.4.0
22
# https://github.com/mlr-org/actions
3+
# modified to use supercharge/redis-github-action@1.7.0
34
on:
45
workflow_dispatch:
56
inputs:
@@ -32,6 +33,8 @@ jobs:
3233
config:
3334
- {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/bbotk'}
3435
- {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3'}
36+
- {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3misc'}
37+
- {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/paradox'}
3538

3639
steps:
3740
- uses: actions/checkout@v3
@@ -50,9 +53,10 @@ jobs:
5053
with:
5154
extra-packages: any::rcmdcheck
5255
needs: check
56+
error-on: '"note"'
5357

5458
- name: Install dev versions
55-
run: pak::pkg_install(c('${{ matrix.config.dev-package }}'))
59+
run: pak::pkg_install('${{ matrix.config.dev-package }}')
5660
shell: Rscript {0}
5761

5862
- uses: mxschmitt/action-tmate@v3
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
# r cmd check workflow without suggests of the mlr3 ecosystem v0.1.0
2+
# https://github.com/mlr-org/actions
3+
# modified to use supercharge/redis-github-action@1.7.0
4+
on:
5+
workflow_dispatch:
6+
inputs:
7+
debug_enabled:
8+
type: boolean
9+
description: 'Run the build with tmate debugging enabled'
10+
required: false
11+
default: false
12+
push:
13+
branches:
14+
- main
15+
pull_request:
16+
branches:
17+
- main
18+
19+
name: no-suggest-cmd-check
20+
21+
jobs:
22+
no-suggest-cmd-check:
23+
runs-on: ${{ matrix.config.os }}
24+
25+
name: ${{ matrix.config.os }} (${{ matrix.config.r }})
26+
27+
env:
28+
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
29+
30+
strategy:
31+
fail-fast: false
32+
matrix:
33+
config:
34+
- {os: ubuntu-latest, r: 'release'}
35+
36+
steps:
37+
- uses: actions/checkout@v3
38+
39+
- uses: r-lib/actions/setup-pandoc@v2
40+
41+
- uses: r-lib/actions/setup-r@v2
42+
with:
43+
r-version: ${{ matrix.config.r }}
44+
45+
- uses: supercharge/redis-github-action@1.7.0
46+
with:
47+
redis-version: 7
48+
49+
- uses: r-lib/actions/setup-r-dependencies@v2
50+
with:
51+
extra-packages: any::rcmdcheck
52+
needs: check
53+
error-on: '"note"'
54+
dependencies: '"hard"'
55+
56+
- uses: mxschmitt/action-tmate@v3
57+
if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}
58+
with:
59+
limit-access-to-actor: true
60+
61+
- uses: r-lib/actions/check-r-package@v2
62+
with:
63+
args: 'c("--no-manual", "--as-cran")'

.github/workflows/r-cmd-check.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
# r cmd check workflow of the mlr3 ecosystem v0.3.1
1+
# r cmd check workflow of the mlr3 ecosystem v0.4.0
22
# https://github.com/mlr-org/actions
3+
# modified to use supercharge/redis-github-action@1.7.0
34
on:
45
workflow_dispatch:
56
inputs:
@@ -50,6 +51,7 @@ jobs:
5051
with:
5152
extra-packages: any::rcmdcheck
5253
needs: check
54+
error-on: '"note"'
5355

5456
- uses: mxschmitt/action-tmate@v3
5557
if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}
@@ -59,4 +61,3 @@ jobs:
5961
- uses: r-lib/actions/check-r-package@v2
6062
with:
6163
args: 'c("--no-manual", "--as-cran")'
62-

R/EnsembleFSResult.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#' `r format_bib("das1999", "meinshausen2010")`
2424
#'
2525
#' @export
26+
#' @examplesIf mlr3misc::require_namespaces("fastVoteR", quietly = TRUE)
2627
#' @examples
2728
#' \donttest{
2829
#' efsr = ensemble_fselect(

man/ensemble_fs_result.Rd

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/mlr_fselectors_async_random_search.Rd

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)