Skip to content

Commit d247ab5

Browse files
authored
release: 0.8.1 (#170)
* release: 0.8.1 * ... * limit number of cores
1 parent b6db512 commit d247ab5

10 files changed

+39
-16
lines changed

DESCRIPTION

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
Package: mlr3filters
22
Title: Filter Based Feature Selection for 'mlr3'
3-
Version: 0.8.0.9000
3+
Version: 0.8.1
44
Authors@R: c(
5+
person("Marc", "Becker", , "marcbecker@posteo.de", role = c("cre", "aut"),
6+
comment = c(ORCID = "0000-0002-8115-0400")),
57
person("Patrick", "Schratz", , "patrick.schratz@gmail.com", role = "aut",
68
comment = c(ORCID = "0000-0003-0748-6624")),
7-
person("Michel", "Lang", , "michellang@gmail.com", role = c("cre", "aut"),
9+
person("Michel", "Lang", , "michellang@gmail.com", role = "aut",
810
comment = c(ORCID = "0000-0001-9754-0393")),
911
person("Bernd", "Bischl", , "bernd_bischl@gmx.net", role = "aut",
1012
comment = c(ORCID = "0000-0001-6002-6980")),

NEWS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# mlr3filters (development version)
1+
# mlr3filters 0.8.1
22

33
* compatibility: mlr3 0.22.0
44

R/Filter.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Filter = R6Class("Filter",
3232
#' Can be set to the scalar value `NA` to allow any task type.
3333
#'
3434
#' For a complete list of possible task types (depending on the loaded packages),
35-
#' see [`mlr_reflections$task_types$type`][mlr_reflections].
35+
#' see [`mlr_reflections$task_types$type`][mlr3::mlr_reflections].
3636
task_types = NULL,
3737

3838
#' @field task_properties (`character()`)\cr

R/FilterBoruta.R

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@
1010
#' The order of selected features is random.
1111
#' In combination with \CRANpkg{mlr3pipelines}, only the filter criterion `cutoff` makes sense.
1212
#'
13+
#' @section Initial parameter values:
14+
#' - `num.threads`:
15+
#' - Actual default: `NULL`, triggering auto-detection of the number of CPUs.
16+
#' - Adjusted value: 1.
17+
#' - Reason for change: Conflicting with parallelization via \CRANpkg{future}.
18+
#'
1319
#' @references
1420
#' `r format_bib("kursa_2010")`
1521
#'
@@ -43,10 +49,11 @@ FilterBoruta = R6Class("FilterBoruta",
4349
doTrace = p_int(lower = 0, upper = 4, default = 0),
4450
holdHistory = p_lgl(default = TRUE),
4551
getImp = p_uty(),
46-
keep = p_fct(levels = c("confirmed", "tentative"), default = "confirmed")
52+
keep = p_fct(levels = c("confirmed", "tentative"), default = "confirmed"),
53+
num.threads = p_int(lower = 1, default = 1)
4754
)
4855

49-
param_set$set_values(keep = "confirmed")
56+
param_set$set_values(keep = "confirmed", num.threads = 1)
5057

5158
super$initialize(
5259
id = "boruta",

R/mlr_filters.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
#' @title Dictionary of Filters
22
#'
3-
#' @format [R6Class] object
3+
#' @format [R6::R6Class] object
44
#' @description
5-
#' A simple [Dictionary] storing objects of class [Filter].
5+
#' A simple [mlr3misc::Dictionary] storing objects of class [Filter].
66
#' Each Filter has an associated help page, see `mlr_filters_[id]`.
77
#'
88
#' This dictionary can get populated with additional filters by add-on packages.
99
#'
1010
#' For a more convenient way to retrieve and construct filters, see [flt()].
1111
#' @section Usage:
1212
#'
13-
#' See [Dictionary].
13+
#' See [mlr3misc::Dictionary].
1414
#'
1515
#' @family Dictionary
1616
#' @family Filter

man/Filter.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/mlr3filters-package.Rd

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/mlr_filters.Rd

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/mlr_filters_boruta.Rd

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/test_filter_regr.R

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ test_that("filters throw errors on missing values", {
3535
})
3636

3737
test_that("Errors for unsupported features", {
38-
skip_if("ames_housing" %nin% mlr_tasks$keys())
39-
task = tsk("ames_housing")
38+
skip_if("california_housing" %nin% mlr_tasks$keys())
39+
task = tsk("california_housing")
4040
filters = mlr_filters$mget(mlr_filters$keys())
4141

4242
# supported: numeric, integer
@@ -47,3 +47,4 @@ test_that("Errors for unsupported features", {
4747
}
4848
}
4949
})
50+

0 commit comments

Comments
 (0)