Skip to content

Commit 9b9d46f

Browse files
committed
fix: property missings of PipeOpFindCorrelation
1 parent 63dab5e commit 9b9d46f

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# mlr3filters 0.7.1-9000
22

33
* Parameter value `na.rm` is properly initialized to `TRUE` (Thanks to @bblodfon)
4+
* Bugfix: property `missings` is now set correctly for `FilterFindCorrelation`
45

56
# mlr3filters 0.7.1
67

R/FilterFindCorrelation.R

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,14 @@ FilterFindCorrelation = R6Class("FilterFindCorrelation",
9494
# The following has the correct names and values, BUT we need scores in
9595
# reverse order. Shift by 1 to get positive values.
9696
1 - apply(cm, 2, max)
97+
},
98+
.get_properties = function() {
99+
use = self$param_set$values$use %??% "everything"
100+
if (use %in% c("complete.obs", "pairwise.complete.obs")) {
101+
"missings"
102+
} else {
103+
character(0)
104+
}
97105
}
98106
)
99107
)

0 commit comments

Comments
 (0)