update test

Author: bblodfon

tests/testthat/test_FilterUnivariateCox.R

@@ -2,20 +2,30 @@ skip_if_not_installed("mlr3proba")
 
 test_that("FilterUnivariateCox", {
   t = tsk("rats")
+  t2 = t$clone()$select(c("rx", "litter"))
   f = flt("univariatecox")
-  f$calculate(t)
+  f$calculate(t2)
 
-  expect_filter(f, task = t)
+  # simple testing of filter scores
+  expect_filter(f, task = t2)
   expect_true(all(f$scores >= 0))
 
-  # works with 2-level factors (but not 3-level ones)
-  feature = "sex"
-  expect_class(t$data(cols = feature)[[1]], "factor")
+  # doesn't work with factors (feature: sex)
+  expect_error(f$calculate(t), "unsupported feature types: factor")
 
+  # encode sex as numeric so filter can be used
+  dt = t$data()
+  dt[, sex := ifelse(dt[["sex"]] == 'm', 1, 0)]
+  t3 = mlr3proba::as_task_surv(dt, target = "time", event = "status")
+  f$calculate(t3)
+  score = f$scores[["sex"]]
+
+  # get manually score on sex factor
   l = lrn("surv.coxph")
-  t2 = t$clone()
-  t2$col_roles$feature = feature
-  l$train(t2)
+  t$col_roles$feature = "sex"
+  l$train(t)
+  manual_score = -log(summary(l$model)$coefficients[,"Pr(>|z|)"])
 
-  expect_equal(-log(summary(l$model)$coefficients[,"Pr(>|z|)"]), f$scores[[feature]])
+  # for 2-level factors, same result is returned if 0-1 encoded
+  expect_equal(manual_score, score)
 })