fix: proper task compability checking

Author: mllg

R/Filter.R

@@ -164,8 +164,8 @@ Filter = R6Class("Filter",
 
       fn = task$feature_names
 
-      if (!is_scalar_na(self$task_types) && task$task_type %nin% self$task_types) {
-        stopf("Filter '%s' does not support the type '%s' of task '%s'",
+      if (!is_scalar_na(self$task_types) && !some(self$task_types, test_matching_task_type, object = task, class = "learner")) {
+        stopf("Filter '%s' not compatible with type '%s' of task '%s'",
           self$id, task$task_type, task$id)
       }
 

R/helper.R

@@ -12,3 +12,23 @@ call_praznik = function(self, task, fun, nfeat) {
 catn = function(..., file = "") {
   cat(paste0(..., collapse = "\n"), "\n", sep = "", file = file)
 }
+
+
+test_matching_task_type = function(task_type, object, class) {
+  fget = function(tab, i, j, key) {
+    x = tab[[key]]
+    tab[[j]][x %chin% i]
+  }
+
+  if (is.null(task_type) || object$task_type == task_type) {
+    return(TRUE)
+  }
+
+  cl_task_type = fget(mlr_reflections$task_types, task_type, class, "type")
+  if (inherits(object, cl_task_type)) {
+    return(TRUE)
+  }
+
+  cl_object = fget(mlr_reflections$task_types, object$task_type, class, "type")
+  return(cl_task_type == cl_object)
+}

tests/testthat/test_mlr3spatiotempcv.R

@@ -0,0 +1,18 @@
+skip_if_not_installed("mlr3spatiotempcv")
+skip_on_cran()
+
+test_that("task detection works with mlr3spatiotempcv tasks", {
+  pkg = "mlr3spatiotempcv"
+  library(pkg, character.only = TRUE) # FIXME: replace with requireNamespace()
+  task = tsk("ecuador")
+  learner = lrn("classif.rpart")
+
+  filter = flt("importance", learner = learner)
+  expect_filter(filter$calculate(task))
+
+  filter = flt("variance")
+  expect_filter(filter$calculate(task))
+
+  filter = flt("mim")
+  expect_filter(filter$calculate(task))
+})