Undo the decision to publish incomplete types to the binding table

mlechu · mlechu · commit cfc566c5c1b8 · 2025-04-02T12:27:52.000-07:00
Part of JuliaLang/julia#56497. `insert-struct-shim` (for the a self-reference case) is omitted for now.
diff --git a/src/desugaring.jl b/src/desugaring.jl
@@ -3954,16 +3954,17 @@ function expand_struct_def(ctx, ex, docs)
                                 ]
                             end
                         ]
-                        # Otherwise do an assignment to trigger an error
-                        [K"const" global_struct_name struct_name]
                     ]
-                    [K"const" global_struct_name struct_name]
                 ]
                 [K"call"(type_body)
                     "_typebody!"::K"core"
                     struct_name
                     [K"call" "svec"::K"core" field_types...]
                 ]
+                [K"const"
+                    [K"globalref" struct_name]
+                    struct_name
+                 ]
                 # Default constructors
                 if isempty(inner_defs)
                     default_inner_constructors(ctx, ex, global_struct_name,

Original file line number	Diff line number	Diff line change
`@@ -3954,16 +3954,17 @@ function expand_struct_def(ctx, ex, docs)`
`3954`	`3954`	`]`
`3955`	`3955`	`end`
`3956`	`3956`	`]`
`3957`		`- # Otherwise do an assignment to trigger an error`
`3958`		`- [K"const" global_struct_name struct_name]`
`3959`	`3957`	`]`
`3960`		`- [K"const" global_struct_name struct_name]`
`3961`	`3958`	`]`
`3962`	`3959`	`[K"call"(type_body)`
`3963`	`3960`	`"_typebody!"::K"core"`
`3964`	`3961`	`struct_name`
`3965`	`3962`	`[K"call" "svec"::K"core" field_types...]`
`3966`	`3963`	`]`
	`3964`	`+ [K"const"`
	`3965`	`+ [K"globalref" struct_name]`
	`3966`	`+ struct_name`
	`3967`	`+ ]`
`3967`	`3968`	`# Default constructors`
`3968`	`3969`	`if isempty(inner_defs)`
`3969`	`3970`	`default_inner_constructors(ctx, ex, global_struct_name,`