How are the submodules set up after cloning?

[anthonybuo]

I'm currently working through the Development/Linux section of the readme trying to build everything and I get the following error when running make in my build directory:

~/dev/Matrix/build$ make
[  2%] Built target unary_minus
[  3%] Built target string_to_double
[  5%] Built target sqrt
[  7%] Built target reciprocal
[  9%] Built target power
[ 11%] Built target determinant
[ 13%] Built target slice_select
[ 14%] Built target inverse
[ 16%] Built target transpose
[ 18%] Built target indexing
[ 20%] Built target argmin_argmax
[ 21%] Built target min_max
[ 23%] Built target abs
[ 24%] Built target concatenate
[ 26%] Built target addition
[ 28%] Built target log
[ 29%] Built target element_wise_multiplication
[ 31%] Built target exp
[ 33%] Built target matrix_calc
[ 34%] Built target slice_matrix
[ 36%] Built target genfromtxt
[ 37%] Built target get_mat
[ 39%] Built target initialize
[ 41%] Built target view_matrix
[ 43%] Built target delete_
[ 45%] Built target matrix_multiplication
[ 46%] Building CXX object benchmarks/CMakeFiles/BM_unary_minus.dir/BM_unary_minus.cpp.o
/home/anthony/dev/Matrix/benchmarks/BM_unary_minus.cpp:2:10: fatal error: benchmark/benchmark.h: No such file or directory
 #include <benchmark/benchmark.h>
          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
benchmarks/CMakeFiles/BM_unary_minus.dir/build.make:81: recipe for target 'benchmarks/CMakeFiles/BM_unary_minus.dir/BM_unary_minus.cpp.o' failed
make[2]: *** [benchmarks/CMakeFiles/BM_unary_minus.dir/BM_unary_minus.cpp.o] Error 1
CMakeFiles/Makefile2:1062: recipe for target 'benchmarks/CMakeFiles/BM_unary_minus.dir/all' failed
make[1]: *** [benchmarks/CMakeFiles/BM_unary_minus.dir/all] Error 2
Makefile:102: recipe for target 'all' failed
make: *** [all] Error 2

I'm not super familiar with git but my understanding is that lib/ contains some submodules that need to be initialized before building. Currently lib/benchmark/ and lib/googletest/ are empty directories for me so I'm wondering how to set this up considering there's no .gitsubmodule file anywhere.

Thanks for the help! Let me know if there's a better place to post this.

[ashok-arora]

I'm not super familiar with git but my understanding is that lib/ contains some submodules that need to be initialized before building. Currently lib/benchmark/ and lib/googletest/ are empty directories for me so I'm wondering how to set this up considering there's no .gitsubmodule file anywhere.

Indeed, there's a missing .gitmodules file here, thanks for pointing it out!
I will send in a PR to fix that.

Edit 1: Fixed in #71.