From 8a2789784874917be6e0fbd52d605c5ff4da926a Mon Sep 17 00:00:00 2001 From: Arjun Suresh Date: Sat, 8 Mar 2025 22:54:28 +0000 Subject: [PATCH 1/2] Update test-mlc-script-features.yml --- .github/workflows/test-mlc-script-features.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/test-mlc-script-features.yml b/.github/workflows/test-mlc-script-features.yml index 05d62e2ae..a61f6b3c7 100644 --- a/.github/workflows/test-mlc-script-features.yml +++ b/.github/workflows/test-mlc-script-features.yml @@ -43,6 +43,8 @@ jobs: mlcr get,dataset,preprocessed,imagenet,_NHWC --quiet mlc search cache --tags=get,dataset,preprocessed,imagenet,-_NCHW mlc search cache --tags=get,dataset,preprocessed,imagenet,-_NHWC + # Tests run-scripts on windows,ubuntu,macos + mlcr get,wkhtmltopdf - name: Test versions continue-on-error: true @@ -52,6 +54,8 @@ jobs: test $? -eq 0 || exit $? mlcr get,generic-python-lib,_package.scipy --version=1.9.2 --quiet test $? -eq 0 || exit $? + mlc find cache --tags=get,generic-python-lib,_package.scipy,version-1.9.3 + test $? -eq 0 || exit $? # Need to add find cache here # mlcr get,generic-python-lib,_package.scipy --version=1.9.3 --quiet --only_execute_from_cache=True # test $? -eq 0 || exit 0 From 3d9e0c70ea05ec97509e80ee47471050bb46f398 Mon Sep 17 00:00:00 2001 From: Arjun Date: Sat, 8 Mar 2025 22:58:22 +0000 Subject: [PATCH 2/2] Fix windows install for wkhtmltopdf --- script/get-wkhtmltopdf/run.bat | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/script/get-wkhtmltopdf/run.bat b/script/get-wkhtmltopdf/run.bat index a172d0b66..6ccb6b19a 100644 --- a/script/get-wkhtmltopdf/run.bat +++ b/script/get-wkhtmltopdf/run.bat @@ -1,14 +1,11 @@ -@echo off -setlocal - :: Define download URL and filename -set "URL=https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6.1-2/wkhtmltox-0.12.6-1.msvc2015-win64.exe" +set "URL=https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6-1/wkhtmltox-0.12.6-1.msvc2015-win64.exe" set "FILE=wkhtmltox-0.12.6-1.msvc2015-win64.exe" :: Download the installer if it doesn't already exist if not exist "%FILE%" ( echo Downloading %FILE%... - powershell -Command "(New-Object System.Net.WebClient).DownloadFile('%URL%', '%CD%\%FILE%')" + powershell -Command "(New-Object System.Net.WebClient).DownloadFile('%URL%', '%CD%\\%FILE%')" if %ERRORLEVEL% neq 0 ( echo Download failed! exit /b %ERRORLEVEL% @@ -17,7 +14,7 @@ if not exist "%FILE%" ( :: Install the software (silent mode) echo Installing wkhtmltopdf... -start /wait %FILE% /S +start /wait %FILE% /quiet if %ERRORLEVEL% neq 0 ( echo Installation failed!