Skip to content

Commit ff18781

Browse files
authored
Fixes for nvidia-mlperf-inference (#152)
* Added variation for nvidia scratch space * Fix docker_utils import in script module
1 parent 1fcac94 commit ff18781

File tree

6 files changed

+19
-5
lines changed

6 files changed

+19
-5
lines changed

automation/script/docker_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def prepare_docker_inputs(input_params, docker_settings,
104104
keys = [
105105
"mlc_repo", "mlc_repo_branch", "base_image", "os", "os_version",
106106
"mlc_repos", "skip_mlc_sys_upgrade", "extra_sys_deps",
107-
"gh_token", "fake_run_deps", "run_final_cmds", "real_run", "copy_files", "path"
107+
"gh_token", "fake_run_deps", "run_final_cmds", "real_run", "copy_files", "path", "user"
108108
]
109109

110110
if run_stage:

automation/script/module.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4950,7 +4950,7 @@ def find_cached_script(i):
49504950
# TODO Need to restrict the below check to within container
49514951
# env
49524952
i['tmp_dep_cached_path'] = dependent_cached_path
4953-
import script.docker_utils
4953+
from script import docker_utils
49544954
r = docker_utils.utils.get_container_path_script(i)
49554955
if not os.path.exists(r['value_env']):
49564956
# Need to rm this cache entry

script/app-mlperf-inference/meta.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1671,6 +1671,8 @@ variations:
16711671
tags: _ctuning
16721672
intel-harness:
16731673
tags: _v3.1
1674+
nvidia-scratch-space:
1675+
tags: _version.4_0-dev
16741676
default_env:
16751677
MLC_SKIP_SYS_UTILS: 'yes'
16761678
MLC_REGENERATE_MEASURE_FILES: 'yes'
@@ -1709,6 +1711,8 @@ variations:
17091711
tags: _mlcommons
17101712
intel-harness:
17111713
tags: _v4.0
1714+
nvidia-scratch-space:
1715+
tags: _version.4_1-dev
17121716
default_env:
17131717
MLC_SKIP_SYS_UTILS: 'yes'
17141718
MLC_REGENERATE_MEASURE_FILES: 'yes'
@@ -1725,6 +1729,8 @@ variations:
17251729
tags: _go
17261730
intel-harness:
17271731
tags: _v4.1
1732+
nvidia-scratch-space:
1733+
tags: _version.4_1
17281734
default_env:
17291735
MLC_SKIP_SYS_UTILS: 'yes'
17301736
MLC_REGENERATE_MEASURE_FILES: 'yes'
@@ -1746,6 +1752,8 @@ variations:
17461752
tags: _v4.1
17471753
inference-src:
17481754
version: r5.0
1755+
nvidia-scratch-space:
1756+
tags: _version.5.0-dev
17491757
default_env:
17501758
MLC_SKIP_SYS_UTILS: 'yes'
17511759
MLC_REGENERATE_MEASURE_FILES: 'yes'
@@ -1901,6 +1909,7 @@ docker:
19011909
interactive: True
19021910
extra_run_args: ' --dns 8.8.8.8 --dns 8.8.4.4 --cap-add SYS_ADMIN --cap-add SYS_TIME --security-opt apparmor=unconfined --security-opt seccomp=unconfined'
19031911
os: ubuntu
1912+
user: mlcuser
19041913
mlc_repo: mlcommons@mlperf-automations
19051914
mlc_repo_branch: dev
19061915
real_run: False

script/build-dockerfile/meta.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ input_mapping:
5656
skip_mlc_sys_upgrade: MLC_DOCKER_SKIP_MLC_SYS_UPGRADE
5757
push_image: MLC_DOCKER_PUSH_IMAGE
5858
docker_not_pull_update: MLC_DOCKER_NOT_PULL_UPDATE
59+
user: MLC_DOCKER_USER
5960

6061
new_env_keys:
6162
- MLC_DOCKERFILE_*

script/build-mlperf-inference-server-nvidia/meta.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,6 @@ variations:
191191
add_deps_recursive:
192192
nvidia-inference-common-code:
193193
version: r4.0
194-
nvidia-scratch-space:
195-
tags: _version.4_1
196194
deps:
197195
- tags: get,generic,sys-util,_git-lfs
198196
- tags: install,pytorch,from.src,_for-nvidia-mlperf-inference-v4.0
@@ -344,6 +342,8 @@ docker:
344342
scratch_path: MLPERF_SCRATCH_PATH
345343
deps:
346344
- tags: get,mlperf,inference,nvidia,scratch,space
345+
names:
346+
- nvidia-scratch-space
347347
- tags: get,mlperf,inference,results,dir,local
348348
- tags: get,mlperf,inference,submission,dir,local
349349
- tags: get,nvidia-docker

script/get-mlperf-inference-nvidia-scratch-space/meta.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,12 @@ variations:
3939
MLC_NVIDIA_SCRATCH_SPACE_VERSION: '4_1'
4040
group: version
4141
version.4_1-dev:
42-
default: true
4342
env:
4443
MLC_NVIDIA_SCRATCH_SPACE_VERSION: 4_1-dev
4544
group: version
45+
version.5_0-dev:
46+
default: true
47+
env:
48+
MLC_NVIDIA_SCRATCH_SPACE_VERSION: 5_0-dev
49+
group: version
4650
versions: {}

0 commit comments

Comments
 (0)