test: updated LoginScreenTest to use semantics instead of tags

Author: C706049

app/src/main/java/com/monstarlab/features/login/ui/LoginScreen.kt

@@ -13,7 +13,6 @@ import androidx.compose.material.Scaffold
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.text.input.PasswordVisualTransformation
 import com.monstarlab.core.error.displayableMessage
 import com.monstarlab.core.ui.previews.LightDarkPreview
@@ -46,9 +45,8 @@ fun LoginScreen(state: LoginState = LoginState(), actions: LoginActions = LoginA
                 value = state.email,
                 onValueChange = actions.onEmailChange,
                 placeholder = "E-Mail",
-                modifier = Modifier
-                    .fillMaxWidth()
-                    .testTag("email"),
+                label = "E-Mail",
+                modifier = Modifier.fillMaxWidth()
             )
 
             Spacer(modifier = Modifier.size(Theme.dimensions.medium3))
@@ -59,19 +57,17 @@ fun LoginScreen(state: LoginState = LoginState(), actions: LoginActions = LoginA
                 error = state.error?.displayableMessage,
                 visualTransformation = PasswordVisualTransformation(),
                 placeholder = "Password",
-                modifier = Modifier
-                    .fillMaxWidth()
-                    .testTag("password"),
+                label = "Password",
+                modifier = Modifier.fillMaxWidth(),
             )
+
             Spacer(modifier = Modifier.size(Theme.dimensions.medium3))
 
             AppButton(
                 text = "Login",
                 onClick = actions.onLoginClick,
                 isLoading = state.isLoading,
-                modifier = Modifier
-                    .fillMaxWidth()
-                    .testTag("login"),
+                modifier = Modifier.fillMaxWidth(),
             )
         }
     }

app/src/test/java/com/monstarlab/features/login/ui/LoginScreenTest.kt

@@ -3,9 +3,10 @@ package com.monstarlab.features.login.ui
 import androidx.compose.ui.test.assert
 import androidx.compose.ui.test.assertIsDisplayed
 import androidx.compose.ui.test.assertIsEnabled
+import androidx.compose.ui.test.hasClickAction
 import androidx.compose.ui.test.hasText
 import androidx.compose.ui.test.junit4.createComposeRule
-import androidx.compose.ui.test.onNodeWithTag
+import androidx.compose.ui.test.onNodeWithText
 import androidx.compose.ui.test.performClick
 import androidx.compose.ui.test.performTextReplacement
 import androidx.test.ext.junit.runners.AndroidJUnit4
@@ -44,18 +45,18 @@ class LoginScreenTest {
     @Test
     fun testInitialState() {
         composeTestRule
-            .onNodeWithTag("email")
+            .onNodeWithText("E-Mail")
             .assertIsEnabled()
             .assertIsDisplayed()
             .assert(hasText("eve.holt@reqres.in"))
 
         composeTestRule
-            .onNodeWithTag("password")
+            .onNodeWithText("Password")
             .assertIsEnabled()
             .assertIsDisplayed()
 
         composeTestRule
-            .onNodeWithTag("login")
+            .onNode(hasText("Login") and hasClickAction())
             .assertIsEnabled()
             .assertIsDisplayed()
     }
@@ -72,7 +73,7 @@ class LoginScreenTest {
     @Test
     fun testEmailInput() {
         composeTestRule
-            .onNodeWithTag("email")
+            .onNodeWithText("E-Mail")
             .performTextReplacement("test@test.com")
 
         verify { mockActions.onEmailChange("test@test.com") }
@@ -90,7 +91,7 @@ class LoginScreenTest {
     @Test
     fun testPasswordInput() {
         composeTestRule
-            .onNodeWithTag("password")
+            .onNodeWithText("Password")
             .performTextReplacement("secret")
 
         verify { mockActions.onPasswordChange("secret") }
@@ -106,7 +107,9 @@ class LoginScreenTest {
      */
     @Test
     fun testLoginButtonClick() {
-        composeTestRule.onNodeWithTag("login").performClick()
+        composeTestRule
+            .onNode(hasText("Login") and hasClickAction())
+            .performClick()
 
         verify { mockActions.onLoginClick() }
     }