Fix word variable mutability (#325)

JustinMeans · web-flow · commit f289633886d9 · 2025-06-03T22:58:30.000-07:00
diff --git a/Libraries/Embedders/Bert.swift b/Libraries/Embedders/Bert.swift
@@ -41,7 +41,7 @@ private class BertEmbedding: Module {
         tokenTypeIds: MLXArray? = nil
     ) -> MLXArray {
         let posIds = positionIds ?? broadcast(MLXArray.arange(inputIds.dim(1)), to: inputIds.shape)
-        let words = wordEmbeddings(inputIds) + positionEmbeddings(posIds)
+        var words = wordEmbeddings(inputIds) + positionEmbeddings(posIds)
         if let tokenTypeIds, let tokenTypeEmbeddings {
             words += tokenTypeEmbeddings(tokenTypeIds)
         }
diff --git a/Libraries/Embedders/NomicBert.swift b/Libraries/Embedders/NomicBert.swift
@@ -35,7 +35,7 @@ class NomicEmbedding: Module {
         _ inputIds: MLXArray, positionIds: MLXArray? = nil,
         tokenTypeIds: MLXArray? = nil
     ) -> MLXArray {
-        let words = wordEmbeddings(inputIds)
+        var words = wordEmbeddings(inputIds)
 
         if let tokenTypeIds, let tokenTypeEmbeddings {
             words += tokenTypeEmbeddings(tokenTypeIds)

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ private class BertEmbedding: Module {`
`41`	`41`	`tokenTypeIds: MLXArray? = nil`
`42`	`42`	`) -> MLXArray {`
`43`	`43`	`let posIds = positionIds ?? broadcast(MLXArray.arange(inputIds.dim(1)), to: inputIds.shape)`
`44`		`- let words = wordEmbeddings(inputIds) + positionEmbeddings(posIds)`
	`44`	`+ var words = wordEmbeddings(inputIds) + positionEmbeddings(posIds)`
`45`	`45`	`if let tokenTypeIds, let tokenTypeEmbeddings {`
`46`	`46`	`words += tokenTypeEmbeddings(tokenTypeIds)`
`47`	`47`	`}`